Add support for RestSharp versions between 106.6.10 and 107.x #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nr-ahemsath
deleted the
restsharp-instruentation-version-filtering-106
branch
chynesNR
added a commit
that referenced
this pull request
Jan 24, 2023
* Instrumentation by assembly version * Updating precompiled Profiler binaries * Removed special case System.Net.Http logic (#1344) * Add support for RestSharp versions between 106.6.10 and 107.x (#1352) * Updates StackExchange.Redis v2 and above to use a new wrapper with improved performance (#1351) * Add new StackExchange.Redis instrumentation to MSI * Add integration test coverage for RestSharp v107+ (#1356) * Update CHANGELOG.md Co-authored-by: Alex Hemsath <57361211+nr-ahemsath@users.noreply.github.com> Co-authored-by: Jacob Affinito <jaffinito@newrelic.com> Co-authored-by: Josh Coleman <83677148+JcolemanNR@users.noreply.github.com> Co-authored-by: Josh Coleman <jcoleman@newrelic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the instrumentation assembly version filtering to add support for RestSharp clients with versions greater than 106.6.10 (the previous highest tested/supported version) and less than 107.x.
The two main changes required were:
ExecuteAsync(RestSharp.IRestRequest,System.Threading.CancellationToken)method in newer 106.x versions instead ofExecuteTaskAsync(RestSharp.IRestRequest,System.Threading.CancellationToken), using the same wrapper.ConfigureWebRequest(System.String,System.Uri)method as a point to add our tracing data headers in newer 106.x versions, since theAppendHeadersmethod we previously instrumented was changed to a local method with no arguments. A new wrapper is used for this, since ConfigureWebRequest returns an HttpWebRequest rather than accepting one as an argument as AppendHeaders did.Note: because we are filtering on assembly version, not package version, and because some of the RestSharp versions between 106.6.10 and 107.x have the AssemblyVersion set to "106.0.0.0", we will only be able to claim support for some of the newer versions, full list TBD (and will definitely be documented on our public docs). I'll also put that info in the changelog when I do that before this PR is merged.
Author Checklist
Performance testing completed with satisfactory results (if required)Reviewer Checklist