Assembly version filtering #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First pass at supporting assembly version targeting in extensions
Fixed use of Windows-specific string functions
First pass at expanding version filtering unit tests
Updating precompiled Profiler binaries after version filtering changes
Replaced hard-coded System.Net.Http logic with version filtering
JcolemanNR
reviewed
Jan 18, 2023
* WIP * Add ConfigureWebRequest wrapper * Comments and cleanup * Changelog update
…proved performance (#1351) * Added new wrapper for StackExchange.Redis v2 and above * Add and update unit tests for StackExchange.Redis * Add new StackExchange.Redis instrumentation to MSI * StackExchange.Redis v2+ cleaned up and simplfied * Add new StackExchange.Redis files to ArtifactBuilder * Rework the ProfilingSession slightly
Final cleanup and changelog update
* update restsharp test harness to v107+ apis * Separate RestSharpExerciser implementation based on target platform * Integration tests don't need to write to random files on disk :)
JcolemanNR
changed the title
JcolemanNR
suggested changes
Jan 23, 2023
...edApplications/Common/MultiFunctionApplicationHelpers/MultiFunctionApplicationHelpers.csproj
Outdated
Show resolved
Hide resolved
...edApplications/Common/MultiFunctionApplicationHelpers/MultiFunctionApplicationHelpers.csproj
Outdated
Show resolved
Hide resolved
tippmar-nr
previously approved these changes
Jan 23, 2023
PR feedback
…ithub.com/newrelic/newrelic-dotnet-agent into instrumentation-version-filtering-feature
Codecov Report
@@ Coverage Diff @@
## main #1342 +/- ##
==========================================
- Coverage 71.68% 71.66% -0.02%
==========================================
Files 459 459
Lines 30484 30542 +58
==========================================
+ Hits 21852 21889 +37
- Misses 8632 8653 +21
|
nrcventura
reviewed
Jan 23, 2023
nrcventura
reviewed
Jan 23, 2023
nrcventura
reviewed
Jan 23, 2023
src/Agent/NewRelic/Agent/Extensions/NewRelic.Agent.Extensions/Api/ISegment.cs
Show resolved
Hide resolved
Update precompiled Linux Profiler
JcolemanNR
approved these changes
Jan 23, 2023
nrcventura
reviewed
Jan 24, 2023
nrcventura
reviewed
Jan 24, 2023
src/Agent/NewRelic/Profiler/ConfigurationTest/InstrumentationConfigurationTest.cpp
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows instrumentation to target a specific range of versions for a given assembly.
Author Checklist
Reviewer Checklist