Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Reject test runners when non-zero exit code #269

Merged
merged 1 commit into from
Jun 19, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/neutrino-preset-karma/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@ module.exports = (neutrino, opts = {}) => {
}
};

neutrino.on('test', ({ files, watch }) => new Promise(resolve =>
neutrino.on('test', ({ files, watch }) => new Promise((resolve, reject) =>
new Server(merge.all([
opts.override ? opts : merge(defaults, opts),
{ singleRun: !watch, autoWatch: watch, webpack: omit(['plugins'], neutrino.config.toConfig()) },
files && files.length ? { files } : {}
]), resolve)
]), exitCode => (exitCode !== 0 ? reject() : resolve()))
.start()
));
};
4 changes: 2 additions & 2 deletions packages/neutrino-preset-mocha/src/mocha.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const toParam = require('change-case').paramCase;

let proc;

module.exports = (mochaOpts = {}, babelOpts = {}, files = []) => new Promise((resolve) => {
module.exports = (mochaOpts = {}, babelOpts = {}, files = []) => new Promise((resolve, reject) => {
if (proc) {
proc.kill();
}
Expand All @@ -26,5 +26,5 @@ module.exports = (mochaOpts = {}, babelOpts = {}, files = []) => new Promise((re
stdio: 'inherit'
});

proc.on('close', resolve);
proc.on('close', code => (code !== 0 ? reject() : resolve()));
});