Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Reject test runners when non-zero exit code #269

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Reject test runners when non-zero exit code #269

merged 1 commit into from
Jun 19, 2017

Conversation

eliperelman
Copy link
Member

No description provided.

@eliperelman eliperelman requested a review from edmorley June 19, 2017 17:53
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

I wonder if we need some tests for this? If karma/mocha exit zero when no tests found, perhaps this can be as simple as trying to run them with no tests?

@eliperelman
Copy link
Member Author

@edmorley I really want to get to the place where we can have better integration-style tests. Right now all the tests for middleware and presets are sanity-based: as long as neutrino is able to require and use them, we let everything move forward.

It would be nice if preset tests could validate their output: either by running neutrino with the preset and making it doesnt bomb, or validating the actual output.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants