Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject.toml and Github Actions #4

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

alexfikl
Copy link
Contributor

@alexfikl alexfikl commented Nov 25, 2024

This ports from setup.py to pyproject.toml and adds workflows for Github Actions. For the CI, you can see a run here (figured out I can just run it on my fork :\)
https://github.com/alexfikl/jitcxde_common/actions/runs/12017074559

As suggested the actions test both gcc and clang. I haven't managed to pass the OpenMP tests with clang locally either, so not quite sure that still works. Have you tried it recently? It seems to pass on an older ubuntu, so maybe there's a dependency missing..

xref: neurophysik/CHSPy#5

@alexfikl alexfikl force-pushed the update-build-system branch from 4e95815 to 74e5b2f Compare November 25, 2024 19:10
@alexfikl alexfikl marked this pull request as ready for review November 25, 2024 19:11
@alexfikl alexfikl force-pushed the update-build-system branch 2 times, most recently from 75932c5 to be0d072 Compare November 25, 2024 19:18
@Wrzlprmft
Copy link
Contributor

I haven't managed to pass the OpenMP tests with clang locally either, so not quite sure that still works. Have you tried it recently? It seems to pass on an older ubuntu, so maybe there's a dependency missing..

Both, OpenMP and Clang work fine for me on Arch. I also think a dependency might be missing. I am surprised that any of this works without installing additional dependencies. The key error appears to be:

/usr/bin/ld: cannot find -lomp: No such file or directory

@alexfikl alexfikl force-pushed the update-build-system branch from be0d072 to 8fca8eb Compare November 26, 2024 08:52
@alexfikl
Copy link
Contributor Author

/usr/bin/ld: cannot find -lomp: No such file or directory

Yeah, that was it. It was just missing the LLVM OpenMP library, which comes separately. The clang tests now pass both locally and on the CI:
https://github.com/alexfikl/jitcxde_common/actions/runs/12026996942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants