Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build system to pyproject.toml #5

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

alexfikl
Copy link
Contributor

@alexfikl alexfikl commented Nov 4, 2024

This makes two changes:

  • Updates the build system to use pyproject.toml
  • Adds a CI using Github Actions to test that everything works on all the supported versions.

Unfortunately, the build system changes seem to require bumping the minimum python version. setuptools v64.0 (the first one that supports pyproject.toml configuration) requires Python >=3.7. The currently maintained Python versions are >=3.9 though (Python 3.8 went in October 2024).

Also, the CI changes won't take effect until they're actually merged to master, so not very helpful to see if they work now. Let me know how you want to handle things and however I can help! 😁

@alexfikl alexfikl force-pushed the update-build-system branch from fa0d25a to 04498e1 Compare November 4, 2024 13:13
@Wrzlprmft
Copy link
Collaborator

Thank you for tackling this. Unfortunately, this pull request came at an inopportune moment. Given that I need check some things myself, as you noticed, it will take a bit more till I can get to it.

@alexfikl
Copy link
Contributor Author

Thank you for tackling this. Unfortunately, this pull request came at an inopportune moment. Given that I need check some things myself, as you noticed, it will take a bit more till I can get to it.

That's not a problem at all! They're more of a quality of life sort of changes, so not urgent in any way.

@Wrzlprmft Wrzlprmft marked this pull request as ready for review November 21, 2024 15:00
@Wrzlprmft Wrzlprmft merged commit e6239dd into neurophysik:master Nov 21, 2024
@Wrzlprmft
Copy link
Collaborator

So, I merged this and there seems to be a syntax problem with the CI file. Unfortunately the error message is not very informative. I would have to either continue with trial and error or figure out some way to test these files outside a live repository.

@alexfikl alexfikl deleted the update-build-system branch November 21, 2024 15:44
@alexfikl
Copy link
Contributor Author

So, I merged this and there seems to be a syntax problem with the CI file. Unfortunately the error message is not very informative. I would have to either continue with trial and error or figure out some way to test these files outside a live repository.

Oops! Sorry for not checking that better. #6 should address that (as soon as I make the 3.6 run work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants