-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opentelemetry support #628
Closed
glazychev-art
wants to merge
2
commits into
networkservicemesh:main
from
glazychev-art:opentelemetry
Closed
Add opentelemetry support #628
glazychev-art
wants to merge
2
commits into
networkservicemesh:main
from
glazychev-art:opentelemetry
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiodo
reviewed
Dec 22, 2020
glazychev-art
force-pushed
the
opentelemetry
branch
3 times, most recently
from
December 25, 2020 09:32
0620938
to
1c00716
Compare
glazychev-art
force-pushed
the
opentelemetry
branch
2 times, most recently
from
December 25, 2020 10:27
1c031ce
to
471d1e3
Compare
glazychev-art
force-pushed
the
opentelemetry
branch
6 times, most recently
from
February 26, 2021 08:15
4dd435a
to
537acce
Compare
@glazychev-art Is this still blocked? If not, should we remove the blocked tag? |
@edwarnicke This is still blocked by #744 |
glazychev-art
force-pushed
the
opentelemetry
branch
3 times, most recently
from
June 18, 2021 11:28
004e9a0
to
b09998d
Compare
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
opentelemetry
branch
from
August 13, 2021 10:21
b09998d
to
9c480db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds opentelemetry support.
At the moment, you can use either
opentracing
(jaeger) oropentelemetry
functional. The latter also provides the ability to work with metrics.How does it work?
The choice of using one of the functional is made through the environment variable.
Opentracing
is used by default (selected as more stable).Opentelemetry initialization is available through
opentelemetry
package. It creates tracer and meter providers.Next,
spanlogger
uses corresponding spans for tracing, andmetrics
chain element works with metrics frompathSegment
.Traces and metrics are sent to
otel-collector
. You can add agents if necessary.So you also need to run
otel-collector
container to receive traces and metrics.How to enable opentelemetry?
TELEMETRY = opentelemetry
.opentelemetry.Init(...)
.Signed-off-by: Artem Glazychev artem.glazychev@xored.com
#584