Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec: OpenTelemetry Integration #584

Closed
tigrulya-exe opened this issue Nov 12, 2020 · 4 comments
Closed

Spec: OpenTelemetry Integration #584

tigrulya-exe opened this issue Nov 12, 2020 · 4 comments
Assignees
@glazychev-art @NikitaSkrynnik
Labels
enhancement New feature or request

Comments

@tigrulya-exe
Copy link
Member

tigrulya-exe commented Nov 12, 2020 •
edited
Loading

We are going to add support for OpenTelemetry. We've investigated OpenTelemetry and added a possible options of integrating it into NSM infrastructure.

Now we need to choose the most suitable OpenTelemetry integration option of those suggested in the spec.

This issue was created for discussions.
@denis-tingaikin denis-tingaikin changed the title Choose the most suitable OpenTelemetry integration option Spec: OpenTelemetry Integration Nov 12, 2020
@denis-tingaikin denis-tingaikin added the enhancement New feature or request label Nov 12, 2020
@denis-tingaikin
Copy link
Member

@edwarnicke, @fkautz Could you take a look?

@glazychev-art
Copy link
Contributor

In implementation we discovered goroutine leakage issues. They are related to the opentelemetry side.
Issues were created describing this problems:
open-telemetry/opentelemetry-go-contrib#501
open-telemetry/opentelemetry-go-contrib#502

They block further work on this issue.
The Draft PR was created.

@edwarnicke
Copy link
Member

@glazychev-art Are we still seeing go routine leaks?

@glazychev-art glazychev-art mentioned this issue Jun 29, 2021
Closed
@NikitaSkrynnik NikitaSkrynnik mentioned this issue Dec 3, 2021
Closed
9 tasks
@denis-tingaikin denis-tingaikin moved this from Todo to In Progress in Release 1.2.0 Dec 14, 2021
@NikitaSkrynnik NikitaSkrynnik mentioned this issue Dec 27, 2021
Merged
9 tasks
@NikitaSkrynnik NikitaSkrynnik mentioned this issue Jan 10, 2022
Merged
9 tasks
@denis-tingaikin
Copy link
Member

All PRs merged. CI passed on kind networkservicemesh/integration-k8s-kind#555

So closing.

Repository owner moved this from In Progress to Done in Release 1.2.0 Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glazychev-art glazychev-art

@NikitaSkrynnik NikitaSkrynnik

Labels
enhancement New feature or request
Projects
Release 1.2.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@edwarnicke @glazychev-art @denis-tingaikin @tigrulya-exe @NikitaSkrynnik