-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detector for Expo #672
Conversation
8cdbada
to
2e55901
Compare
2e55901
to
d9dadb7
Compare
Ideally, there should be a way to inform the user of the URL the proxied server is listening on, because currently the Expo cli clears the terminal and the URL output by |
I tried this locally but the |
Sure thing! Expo actually starts up a bunch of things on different ports:
We want to proxy the Webpack server so that's port Something I just realized though, is that when you start an Expo project with So the reason I'm inclined to use So I guess the best course of action is to just use Expo defaults and add a way to disable opening the browser automatically in |
Thanks for the PR @ianmartorell. |
this is great! thanks ian! |
- Summary
This PR adds a detector for
netlify-cli
to work automagically with Expo projects.Prior to this, every project needed to be configured using
netlify.toml
beforenetlify dev
could be used.This also fixes #333 since
netlify publish
now uses the detector config to find the publish directory.- Test plan
I created a new blank Expo project, ran the
dev
command on that folder and it started up successfully. Then I ran thepublish
command and it didn't ask for the build directory.Note: I also needed to use #669 or the port allocation of the functions server becomes random and
netlify dev
can't connect.- Description for the changelog
Add detector for Expo
- A picture of a cute animal (not mandatory but encouraged)