Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Expo (React Native for web) apps #333

Closed
EvanBacon opened this issue Jun 13, 2019 · 3 comments · Fixed by #672
Closed

Support for Expo (React Native for web) apps #333

EvanBacon opened this issue Jun 13, 2019 · 3 comments · Fixed by #672

Comments

@EvanBacon
Copy link

EvanBacon commented Jun 13, 2019

- Do you want to request a feature or report a bug?

Feature Request

Now with first-class web support coming to React Native it would be great to have feature detection built into the deployment command.

- What is the current behavior?

  • Run expo build:web to generate a static site
  • netlify deploy starts the flow
  • choose a name
  • ? deploy path ( . ) - /web-build

This last step doesn't seem to persist my choice. It'd be cool if it checked to see if the app.json (React Native config file) exists in the root directory, then possibly checks to see if expo.web.build.output is defined (custom output path).

So if /web-build exists and app.json exists you would get the following:

  • ? deploy path (web-build)

and if expo.web.build.output is defined you would get that value as the auto suggested path.

How

I'm happy to work on this PR if you guys are interested.

@EvanBacon EvanBacon changed the title Support for Expo apps Support for Expo (React Native for web) apps Jun 13, 2019
@swyxio
Copy link
Contributor

swyxio commented Jun 14, 2019

hey evan! been watching your RN demos and am very excited you are using netlify!

this request is an excellent use case for splitting out detectors from Netlify Dev: https://github.com/netlify/netlify-dev-plugin/tree/master/src/detectors

we have been planning for this to be a standalone, reusable feature anyway and just need some work to take out some netlify dev specific assumptions.

i think i will need to do some heavy lifting to do this "split out project" and will free up after my conf commitments this week. wont need anything from you in the meantime but thanks for the push.

@lupelius
Copy link

any news with this?

@swyxio
Copy link
Contributor

swyxio commented Mar 25, 2020

no, sorry. i left the company. feel free to open up a new issue/pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants