-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: invoke functions from runtime #2826
Conversation
📊 Benchmark resultsComparing with 8bfdb2f Package size: 330 MB(no change)
Legend
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo, @eduardoboucas this is SO MUCH BETTER.
I added some comments and also noticed an issue with netlify-lambda
.
Since netlify-lambda
populates the configured functions directory, getBuildFunction
will manage to detect it only if it was executed an initial time before reaching that code.
To reproduce:
git clone https://github.com/erezrokah/netlify-build-reproductions
git checkout netlify_lambda
ntl dev
- See that
netlify-lambda
is not detected
If you run
npm run build
a single time the detection works
We can fix this by moving the detection code earlier in the flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the followup @eduardoboucas,
Added 2 clarifications to the review
f48a7d0
to
e2f51c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
3d5d929
to
408bf44
Compare
- Summary
This is the final PR for #2806. Unfortunately, I couldn't break it further down into smaller chunks because all the pieces are heavily interconnected.
I broke each change into its own commit and I'll add as much information as possible in comments, to make this as easy to review as possible.