This repository has been archived by the owner on Aug 10, 2020. It is now read-only.
Update telemetry validation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidWells
added a commit
to netlify/netlify-dev-plugin
that referenced
this pull request
Mar 28, 2019
depends on netlify/cli-utils#5
|
Can you rebase so tests pass? |
|
rebased |
bcomnes
approved these changes
Mar 29, 2019
|
After this merges we need to bump https://github.com/netlify/netlify-dev-plugin/blob/master/package.json#L8 (unless semver does its thing) and merge the PR here netlify/netlify-dev-plugin#49 and it will go live |
|
We can rely on semver so long as its compatible with both arrangements. Otherwise we need to raise the semver floor here. Want to land that plugin change and bump the floor? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.