Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Pipe echo commands to bash shell #389

Merged
merged 2 commits into from
Apr 14, 2020
Merged

Pipe echo commands to bash shell #389

merged 2 commits into from
Apr 14, 2020

Conversation

aarushik93
Copy link
Contributor

Related to issue 217
Clears up all the unneeded logs + runs the commands.

Leaving in 'go version', because original script doesn't have it in qutoes, meaning the command as well as output shows up.

@aarushik93 aarushik93 requested a review from a team as a code owner April 9, 2020 14:07
Copy link
Contributor

@mheffner mheffner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aarushik93 I think there appear to be two locations we run this. The Dockerfile should only be invoked during our own Jenkins CI build of the "build image". My guess is that the output the user is seeing during their builds is coming from the second time we invoke it in the functions script:

.

@aarushik93
Copy link
Contributor Author

ahh updated, thanks for pointing that out!

Copy link
Contributor

@mheffner mheffner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should work, it looks like often you can eval the output of this, but we source the env file right after instead.

@aarushik93 aarushik93 merged commit 3a3e63f into xenial Apr 14, 2020
@aarushik93 aarushik93 deleted the ak/217/tighten-logging branch April 14, 2020 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants