Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

minor: tighten up logging #217

Open
fool opened this issue Nov 15, 2018 · 6 comments
Open

minor: tighten up logging #217

fool opened this issue Nov 15, 2018 · 6 comments
Labels
feat/builds low-priority type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@fool
Copy link
Contributor

fool commented Nov 15, 2018

There are a few loglines in the output of every build we could safely skip IMNSHO. Not saying don't run the commands, just outputting them doesn't serve a purpose I can understand (vs say showing what $PATH is or something ;))

8:29:08 PM: unset GOOS;
8:29:08 PM: unset GOARCH;
8:29:08 PM: export GOROOT='/opt/buildhome/.gimme/versions/go1.10.linux.amd64';
8:29:08 PM: export PATH="/opt/buildhome/.gimme/versions/go1.10.linux.amd64/bin:${PATH}";
8:29:08 PM: go version >&2;
8:29:08 PM: export GIMME_ENV='/opt/buildhome/.gimme/env/go1.10.linux.amd64.env';
@aarushik93
Copy link
Contributor

These log lines are coming from the script from travis CI we use to install go, see here.
Might not be worth trying to remove those logs, if it's low priority?

@mheffner
Copy link
Contributor

mheffner commented Apr 8, 2020

@aarushik93 So are we supposed to be piping those commands into a bash environment? I'm wondering if instead of removing them in that Travis CI file there's a way to not print them when piped?

@fool
Copy link
Contributor Author

fool commented Apr 8, 2020

thinking out loud: we could also fork that travis script, change it, and use our own copy, non?

@mheffner
Copy link
Contributor

mheffner commented Apr 8, 2020

@fool that's absolutely an option, but I think if there's any way we can avoid having to maintain a fork that's ideal. If everyone else (ie Travis) is simply echoing those commands to their output then maybe we need our own version, it seems odd that those shell commands are showing up in output though. I'd be curious if there was a way we were invoking it that were different than expected use.

@aarushik93
Copy link
Contributor

As far as I can see we're not actually piping these commands.
Making commands not print out is just:
set +x, as far as I know.
But some of the commands aren't working when I pipe them as well. eg. go version >&2
Since to pipe and execute it should be in quotes

@aarushik93
Copy link
Contributor

Also, maybe someone can provide me some background on the use of the script from travis as opposed to just installing go ourselves in the container? Maybe that's a possibility too - I believe that would also remove other unnecessary logs?

@verythorough verythorough added type: feature code contributing to the implementation of a feature and/or user facing functionality and removed enhancement labels Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat/builds low-priority type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

No branches or pull requests

4 participants