Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGSTACK-461 Use query type instead of controller for ng category #51

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

RandyCupic
Copy link
Member

@RandyCupic RandyCupic commented Nov 13, 2020

@emodric
Copy link
Member

emodric commented Nov 13, 2020

@pspanja Does this look good to you?

@pspanja
Copy link
Member

pspanja commented Nov 13, 2020

It does, mostly, I'm just not sure about viewParam("childrenLimit", 12), can't figure out where it comes from.

Edit: it seems to be an unused extension point.

@pspanja
Copy link
Member

pspanja commented Nov 14, 2020

Would it be useful to change fetch_subtree field to depth/relative_depth?

@emodric
Copy link
Member

emodric commented Nov 14, 2020

Would it be useful to change fetch_subtree field to depth/relative_depth?

Maybe. We can do it in 1.10 👍

@RandyCupic
Copy link
Member Author

Would it be useful to change fetch_subtree field to depth/relative_depth?

I didn't understand this one: current fetch subtree field only controls whether we will fetch only first level children or everything. I just used relative depth as a way to implement this.

@emodric
Copy link
Member

emodric commented Nov 16, 2020

I think @pspanja was referring to changing the field in the database to be called depth or relative_depth, but it cannot be done easily since it can be a breaking change.

@pspanja
Copy link
Member

pspanja commented Nov 16, 2020

@RandyCupic sorry, it was a kind of a digression on this issue, I meant to ask would it be useful in general, in order to control subtree depth.

@pspanja
Copy link
Member

pspanja commented Nov 16, 2020

@emodric correct, but not just to change the name, but also change it from checkbox to integer. It's separate topic to this issue in any case.

@emodric
Copy link
Member

emodric commented Nov 16, 2020

but also change it from checkbox to integer.

Yes, I figured as much, also :)

It's separate topic to this issue in any case.

👍

@RandyCupic
Copy link
Member Author

I think @pspanja was referring to changing the field in the database to be called depth or relative_depth, but it cannot be done easily since it can be a breaking change.

Ah, I understand now; so it would allow more control by being able to specify any depth.

@emodric emodric merged commit 1ef2c3c into 1.9 Nov 16, 2020
@emodric
Copy link
Member

emodric commented Nov 16, 2020

Thanks @RandyCupic & @pspanja !

@emodric emodric deleted the NGSTACK-461-remove-ng-category-controller branch November 16, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants