-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NGSTACK-461 Use query type instead of controller for ng category #51
Conversation
@pspanja Does this look good to you? |
It does, mostly, I'm just not sure about Edit: it seems to be an unused extension point. |
Would it be useful to change |
Maybe. We can do it in 1.10 👍 |
I didn't understand this one: current fetch subtree field only controls whether we will fetch only first level children or everything. I just used relative depth as a way to implement this. |
I think @pspanja was referring to changing the field in the database to be called |
@RandyCupic sorry, it was a kind of a digression on this issue, I meant to ask would it be useful in general, in order to control subtree depth. |
@emodric correct, but not just to change the name, but also change it from checkbox to integer. It's separate topic to this issue in any case. |
Yes, I figured as much, also :)
👍 |
Ah, I understand now; so it would allow more control by being able to specify any depth. |
Thanks @RandyCupic & @pspanja ! |
Depends on: netgen/ezplatform-site-api#187