NGSTACK-461 Query type improvements #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pspanja
reviewed
Nov 6, 2020
docs/reference/query_types/parameters/common/query/sort/body.rst.inc
Outdated
Show resolved
Hide resolved
pspanja
reviewed
Nov 6, 2020
docs/reference/query_types/parameters/common/query/sort/body.rst.inc
Outdated
Show resolved
Hide resolved
pspanja
reviewed
Nov 6, 2020
pspanja
reviewed
Nov 6, 2020
docs/reference/query_types/parameters/common/query/offset.rst.inc
Outdated
Show resolved
Hide resolved
pspanja
reviewed
Nov 6, 2020
docs/reference/query_types/parameters/common/query/limit.rst.inc
Outdated
Show resolved
Hide resolved
|
Thanks @RandyCupic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes values for query type parameters are being fetched dynamically and, if the dynamic value is NULL, currently it's not possible to avoid adding that criterion. To solve this, this PR enables various parameters to have NULL as value, which will prevent adding that criterion to the Query.
Documentation and tests have been updated accordingly.
Also, this PR introduces new
splitfunction to be used in query parameter values (needed for eg. splitting comma-separated list of supported content type identifiers into array for content type parameter).