Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17374 correct background color in dark mode for active list item #17792

Merged
merged 2 commits into from
Oct 18, 2024
Merged

17374 correct background color in dark mode for active list item #17792

merged 2 commits into from
Oct 18, 2024

Conversation

arthanson
Copy link
Collaborator

Fixes: #17374

PP:B117 | NetBox 2024-10-16 13-08-14

@arthanson arthanson changed the title 17374 correct background color in dark mode for active list item DRAFT: 17374 correct background color in dark mode for active list item Oct 16, 2024
@arthanson arthanson marked this pull request as ready for review October 16, 2024 20:27
@arthanson arthanson changed the title DRAFT: 17374 correct background color in dark mode for active list item 17374 correct background color in dark mode for active list item Oct 16, 2024
jeremystretch
jeremystretch approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down @arthanson

@jeremystretch jeremystretch merged commit e13bc06 into develop Oct 18, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 17374-active-background branch October 18, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

@bctiemann bctiemann Awaiting requested review from bctiemann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Low contrast with active list items (Device Page, Virtual Chassis)
2 participants
@arthanson @jeremystretch