Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low contrast with active list items (Device Page, Virtual Chassis) #17374

Closed
justincjahn opened this issue Sep 4, 2024 · 0 comments · Fixed by #17792
Closed

Low contrast with active list items (Device Page, Virtual Chassis) #17374

justincjahn opened this issue Sep 4, 2024 · 0 comments · Fixed by #17792
Assignees
@arthanson
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application

Comments

@justincjahn
Copy link

justincjahn commented Sep 4, 2024 •
edited by arthanson
Loading

Deployment Type

Self-hosted

NetBox Version

v4.1.0

Python Version

3.10

Steps to Reproduce

  1. Enable the dark mode theme
  2. Create a new virtual chassis
  3. Add one or more Devices to the Virtual Chassis
  4. Open the Device page for any device associated with a Virtual Chassis

Expected Behavior

The highlighted Device in the Virtual Chassis pane should be readable and more consistent with other dark mode UI elements.

Observed Behavior

The highlighted Device appears in the list with a background color that makes it very difficult to read.
PP:B117 | NetBox 2024-09-05 07-39-15
@justincjahn justincjahn added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Sep 4, 2024
@justincjahn justincjahn changed the title Low contract with list items Low contrast with list items (Device Page, Virtual Chassis) Sep 4, 2024
@justincjahn justincjahn changed the title Low contrast with list items (Device Page, Virtual Chassis) Low contrast with active list items (Device Page, Virtual Chassis) Sep 4, 2024
@DanSheps DanSheps added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available topic: UI/UX User interface or user experience related work and removed status: needs triage This issue is awaiting triage by a maintainer labels Sep 5, 2024
@arthanson arthanson added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Oct 16, 2024
@arthanson arthanson self-assigned this Oct 16, 2024
@arthanson arthanson mentioned this issue Oct 16, 2024
Merged
jeremystretch added a commit that referenced this issue Oct 21, 2024
@jeremystretch
Changelog for #17374, #17635, #17774, #17802, #17789
5940f5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthanson arthanson

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

17374 correct background color in dark mode for active list item netbox-community/netbox
3 participants
@arthanson @justincjahn @DanSheps