Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcalc.profile: fix mkfile without mkdir & comment legacy paths #5496

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Dec 1, 2022

kcalc.profile: fix mkfile without mkdir

firejail may fail to create the following files:

  • ~/.kde/share/config/kcalcrc
  • ~/.kde4/share/config/kcalcrc

Because it does not create the preceding directories beforehand:

  • ~/.kde/share/config
  • ~/.kde4/share/config

kcalc.profile: stop creating legacy KDE paths

Leave them commented.

With this commit, there are no more profiles creating paths in ~/.kde
nor in ~/.kde4:

$ git grep -e '^mkdir .*\.kde' -e '^mkfile .*\.kde' -- etc
$

Relates to #5415.

kmk3 added 2 commits December 1, 2022 04:57
firejail may fail to create the following files:

* ~/.kde/share/config/kcalcrc
* ~/.kde4/share/config/kcalcrc

Because it does not create the preceding directories beforehand:

* ~/.kde/share/config
* ~/.kde4/share/config

See also commit 7f1906d ("ktorrent.profile: fix mkfile without mkdir",
2022-10-11) / PR netblue30#5415.
Leave them commented.

With this commit, there are no more profiles creating paths in ~/.kde
nor in ~/.kde4:

    $ git grep -e '^mkdir .*\.kde' -e '^mkfile .*\.kde' -- etc
    $

See also commit 3ef0302 ("ktorrent.profile: stop creating legacy KDE
paths", 2022-10-11) / PR netblue30#5415.
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmk3 kmk3 merged commit 48c3045 into netblue30:master Dec 8, 2022
@kmk3 kmk3 deleted the kcalc-fix-mkfile branch December 8, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants