Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ktorrent.profile: fix mkfile without mkdir & comment legacy paths #5415

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Oct 11, 2022

firejail fails to create the following files:

  • ~/.kde/share/config/ktorrentrc
  • ~/.kde4/share/config/ktorrentrc

Because it does not create the preceding directories beforehand:

  • ~/.kde/share/config
  • ~/.kde4/share/config

Relates to #5414.

@kmk3 kmk3 marked this pull request as draft October 13, 2022 01:21
kmk3 added 3 commits November 22, 2022 02:52
firejail fails to create the following files:

* ~/.kde/share/config/ktorrentrc
* ~/.kde4/share/config/ktorrentrc

Because it does not create the preceding directories beforehand:

* ~/.kde/share/config
* ~/.kde4/share/config

Relates to netblue30#5414.
Package-provided binaries:

    $ pacman -Q ktorrent
    ktorrent 22.08.3-1.2
    $ pacman -Qlq ktorrent | grep bin/.
    /usr/bin/ktmagnetdownloader
    /usr/bin/ktorrent
    /usr/bin/ktupnptest

Environment: Artix Linux
@kmk3 kmk3 force-pushed the ktorrent-fix-mkfile branch from e1d537d to 72b662f Compare November 22, 2022 06:30
@kmk3
Copy link
Collaborator Author

kmk3 commented Nov 22, 2022

Force-push changes:

  • Put the "fix" commit first
  • Also consider ~/.kde paths as legacy paths
  • Add missing private-bin paths

@kmk3 kmk3 marked this pull request as ready for review November 22, 2022 06:32
@kmk3 kmk3 changed the title ktorrent.profile: comment legacy paths & fix mkfile without mkdir ktorrent.profile: fix mkfile without mkdir & comment legacy paths Nov 22, 2022
@netblue30
Copy link
Owner

merged!

@netblue30 netblue30 merged commit 5286ec8 into netblue30:master Nov 25, 2022
@kmk3 kmk3 deleted the ktorrent-fix-mkfile branch November 25, 2022 16:35
kmk3 added a commit to kmk3/firejail that referenced this pull request Dec 1, 2022
firejail may fail to create the following files:

* ~/.kde/share/config/kcalcrc
* ~/.kde4/share/config/kcalcrc

Because it does not create the preceding directories beforehand:

* ~/.kde/share/config
* ~/.kde4/share/config

See also commit 7f1906d ("ktorrent.profile: fix mkfile without mkdir",
2022-10-11) / PR netblue30#5415.
kmk3 added a commit to kmk3/firejail that referenced this pull request Dec 1, 2022
Leave them commented.

With this commit, there are no more profiles creating paths in ~/.kde
nor in ~/.kde4:

    $ git grep -e '^mkdir .*\.kde' -e '^mkfile .*\.kde' -- etc
    $

See also commit 3ef0302 ("ktorrent.profile: stop creating legacy KDE
paths", 2022-10-11) / PR netblue30#5415.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants