-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass HTTP proxy environment variables to the Docker daemon #214
Conversation
Hi @kispaljr. Thanks for your PR. I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind cleanup |
/remove-kind bug |
/ok-to-test |
/test provision-linter |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: radoslawc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-ubuntu-focal |
/retest |
@electrocucaracha , @radoslawc could you take a look? |
/lgtm |
…oject#214) * Pass HTTP proxy environment variables to the Docker daemon and to all ansible tasks * Fix handling missing proxy envvars
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This passes the HTTP proxy environment variables set in the host environment that runs the ansible playbook to the newly installed Docker daemon and to the tasks of the ansible playbook itself.
Which issue(s) this PR fixes:
It is a step toward fixing nephio-project/nephio#409 , but it will not completely fix the issue.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: