Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass HTTP proxy environment variables to the Docker daemon #214

Merged
merged 2 commits into from
Nov 11, 2023

Conversation

kispaljr
Copy link
Contributor

@kispaljr kispaljr commented Nov 3, 2023

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

This passes the HTTP proxy environment variables set in the host environment that runs the ansible playbook to the newly installed Docker daemon and to the tasks of the ansible playbook itself.

Which issue(s) this PR fixes:

It is a step toward fixing nephio-project/nephio#409 , but it will not completely fix the issue.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link
Contributor

nephio-prow bot commented Nov 3, 2023

Hi @kispaljr. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kispaljr
Copy link
Contributor Author

kispaljr commented Nov 3, 2023

/kind cleanup

@kispaljr
Copy link
Contributor Author

kispaljr commented Nov 3, 2023

/remove-kind bug

@nephio-prow nephio-prow bot removed the kind/bug label Nov 3, 2023
@electrocucaracha
Copy link
Member

/ok-to-test

@electrocucaracha
Copy link
Member

/test provision-linter
/test e2e-ubuntu-focal

@electrocucaracha
Copy link
Member

/lgtm

@radoslawc
Copy link
Collaborator

/approve

Copy link
Contributor

nephio-prow bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Nov 8, 2023
@radoslawc
Copy link
Collaborator

/test e2e-ubuntu-focal

@nephio-prow nephio-prow bot removed the lgtm label Nov 8, 2023
@kispaljr
Copy link
Contributor Author

/retest

@kispaljr
Copy link
Contributor Author

kispaljr commented Nov 10, 2023

@electrocucaracha , @radoslawc could you take a look?

@electrocucaracha
Copy link
Member

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Nov 11, 2023
@nephio-prow nephio-prow bot merged commit fe60d23 into nephio-project:main Nov 11, 2023
dkosteck pushed a commit to vjayaramrh/test-infra that referenced this pull request Aug 15, 2024
…oject#214)

* Pass HTTP proxy environment variables to the Docker daemon and to all ansible tasks

* Fix handling missing proxy envvars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants