TASK: 5243 remove ContentGraphFinder runtime cache #5246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaidelich
requested changes
Sep 17, 2024
mhsdesign
force-pushed
the
task/5243-remove-cr-core-runtime-caches
branch
from
b736d61 to
1ad4dd6
Compare
|
Ahh yes good catch, implemented. |
bwaidelich
approved these changes
Sep 17, 2024
kitsunet
approved these changes
Sep 17, 2024
mhsdesign
added a commit
that referenced
this pull request
Oct 1, 2024
With #5246 the cache was naively removed ^^ But with the additional complexity of fetching workspaces etc it makes sense to reintroduce this cache layer.
neos-bot
pushed a commit
to neos/contentgraph-doctrinedbaladapter
that referenced
this pull request
Oct 18, 2024
With neos/neos-development-collection#5246 the cache was naively removed ^^ But with the additional complexity of fetching workspaces etc it makes sense to reintroduce this cache layer.
neos-bot
pushed a commit
to neos/contentgraph-doctrinedbaladapter
that referenced
this pull request
Oct 18, 2024
In commit d57195d the cache invalidation was partly repaired But as we removed the content graph cache layer currently in 9.0 neos/neos-development-collection#5246 A reintroduction will be discussed as part of another change. Related neos/neos-development-collection#5039
neos-bot
pushed a commit
to neos/contentrepository-core
that referenced
this pull request
Oct 18, 2024
With neos/neos-development-collection#5246 the cache was naively removed ^^ But with the additional complexity of fetching workspaces etc it makes sense to reintroduce this cache layer.
neos-bot
pushed a commit
to neos/contentrepository-core
that referenced
this pull request
Oct 18, 2024
In commit c0ce2ba the cache invalidation was partly repaired But as we removed the content graph cache layer currently in 9.0 neos/neos-development-collection#5246 A reintroduction will be discussed as part of another change. Related neos/neos-development-collection#5039
neos-bot
pushed a commit
to neos/contentrepository-testsuite
that referenced
this pull request
Oct 18, 2024
With neos/neos-development-collection#5246 the cache was naively removed ^^ But with the additional complexity of fetching workspaces etc it makes sense to reintroduce this cache layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5244
Related #5242
See #5243
With the removal of the cr core wrapped content subgraph with runtime cache feature and making it a Neos.Neos feature we dont have to cache the content graphs any further as well. (This was initially only done to ensure that the graphs subgraph pool is used)
The only downside to this is that calling
getContentGraphwill now always issue an sql query to get the underlying content stream id. The advantage obviously that its always the latest, but its not cached.