FEATURE: extract content subgraph inmemory caching #5244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not needed anymore because we are now able to flush caches properly because we are not asynchronous anymore
…lly, Does not store subgraphs anymore in memory, but return them on demand
skurfuerst
force-pushed
the
90-5243-extract-content-subgraph-inmemory-caching
branch
from
4fdbf0b to
66193dd
Compare
skurfuerst
force-pushed
the
90-5243-extract-content-subgraph-inmemory-caching
branch
from
66193dd to
99f7cc9
Compare
bwaidelich
reviewed
Sep 13, 2024
bwaidelich
approved these changes
Sep 13, 2024
bwaidelich
deleted the
90-5243-extract-content-subgraph-inmemory-caching
branch
mhsdesign
changed the title
mhsdesign
reviewed
Sep 16, 2024
Comment on lines
+207
to
+211
| $uncachedSubgraph = $contentRepository->getContentGraph($nodeAddress->workspaceName)->getSubgraph( | ||
| $nodeAddress->dimensionSpacePoint, | ||
| VisibilityConstraints::frontend() | ||
| ); | ||
| $subgraph = new ContentSubgraphWithRuntimeCaches($uncachedSubgraph, $this->subgraphCachePool); |
There was a problem hiding this comment.
we probably need an api way of doing this as thats sometimes the case on the boundary where we dont have a $node yet and cannot use the cr registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #5243