Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Fusion avoid error parser cache to crash if cache is broken #4839

Merged
merged 2 commits into from
Feb 5, 2024
Merged

BUGFIX: Fusion avoid error parser cache to crash if cache is broken #4839

merged 2 commits into from
Feb 5, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Jan 16, 2024 •
edited
Loading

Resolves #4595

It seems a cache's has operation doesnt work that reliable thats why we will be using get instead and check against false.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign mentioned this pull request Jan 16, 2024
Closed
Sebobo
Sebobo approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhsdesign mhsdesign requested a review from kitsunet January 16, 2024 14:12
@mhsdesign mhsdesign marked this pull request as draft January 29, 2024 10:19
@mhsdesign mhsdesign force-pushed the bugfix/4595-avoid-parse-partials-cache-to-crash-in-rare-case branch from 6ec8bef to a5eedb2 Compare February 2, 2024 15:12
@mhsdesign
TASK: Alternate fix for fusion partials cache neos#4595
7adf0dd 
> This should not be considered an error. It's a cache, things can happen, it should be able to deal with this.

That's why get will be used directly instead of has.

In the rare edge-case of a fusion dsl returning `false` we cannot cache it anymore.
This is an acceptable compromise.
@mhsdesign mhsdesign force-pushed the bugfix/4595-avoid-parse-partials-cache-to-crash-in-rare-case branch from a5eedb2 to 7adf0dd Compare February 2, 2024 15:13
@mhsdesign mhsdesign marked this pull request as ready for review February 2, 2024 15:13
@mhsdesign mhsdesign merged commit 0a234a6 into neos:8.0 Feb 5, 2024
8 checks passed
@mhsdesign mhsdesign deleted the bugfix/4595-avoid-parse-partials-cache-to-crash-in-rare-case branch February 5, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sebobo Sebobo Sebobo approved these changes

@jonnitto jonnitto jonnitto approved these changes

@kitsunet kitsunet Awaiting requested review from kitsunet

Assignees
No one assigned
Labels
8.0 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhsdesign @kitsunet @Sebobo @jonnitto