Fusion ParserCache crashes when generated value is not a FusionFile

[Sebobo]

In

neos-development-collection/Neos.Fusion/Classes/Core/Cache/ParserCache.php

Line 65 in 6fcba54

return $this->cacheForIdentifier($identifier, $generateValueToCache);

the ParserCache just returns a value from another method that can return a mixed value and doesn't check if the value is actually a FusionFile.
That leads to a crash when the generated value is false due to some other issue with the composer state or stale file cache.

[Sebobo]

Not 100% sure what would be the correct solution here. Even if the main issue is somewhere else, we have to check the type.

[mhsdesign]

A little peace offering: #4839

[mhsdesign]

Is this possibly related? neos/flow-development-collection#3284

Edit sorry no i thought the above happened with redis but seb negated this

[Sebobo]

Is this possibly related? neos/flow-development-collection#3284

How and why?

[kitsunet]

I don't think so, this is a rather special case and should show up as such in the log.

[mhsdesign]

@kitsunet do you like this fix? #4839

feels a bit weird as on other places we are not that forgiving if the cache is broken and would just crash...

it seems $this->parsePartialsCache->has returns true but $this->parsePartialsCache->get false. Impossible. :D

[kitsunet]

Is why I almost never use "has" in caches, it is never atomic, you cannot know what happens between has and get. I prefer

$cacheEntry = $cache->get(...);
If ($cacheEntry === false)  {
   die(); // early return, exception, whatever
}

[mhsdesign]

Should be fixed via #4839