Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner/performance: add improved bulk insert benchmark #9812

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Nov 19, 2024

Adds an improved bulk insert benchmark, including S3 uploads.

Touches #9789.

Copy link

github-actions bot commented Nov 19, 2024

7190 tests run: 6871 passed, 0 failed, 319 skipped (full report)


Flaky tests (2)

Postgres 16

Postgres 15

Code coverage* (full report)

  • functions: 31.4% (8328 of 26508 functions)
  • lines: 47.8% (65520 of 137121 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
14e1e4b at 2024-12-06T16:18:20.498Z :recycle:

@erikgrinaker erikgrinaker force-pushed the erik/benchmark-bulk-insert branch 2 times, most recently from 34e8392 to 20b6afc Compare November 25, 2024 15:14
@erikgrinaker erikgrinaker force-pushed the erik/benchmark-bulk-insert branch from 20b6afc to 874c3fa Compare December 4, 2024 13:35
@erikgrinaker erikgrinaker force-pushed the erik/benchmark-bulk-insert branch from 874c3fa to d05b3da Compare December 4, 2024 16:14
@erikgrinaker erikgrinaker changed the base branch from main to erik/checkpoint-wait December 4, 2024 16:14
@erikgrinaker erikgrinaker force-pushed the erik/benchmark-bulk-insert branch 2 times, most recently from 16bf5b7 to 7a2cb90 Compare December 5, 2024 09:06
@erikgrinaker erikgrinaker marked this pull request as ready for review December 5, 2024 09:08
@erikgrinaker erikgrinaker requested review from a team and skyzh and removed request for a team December 5, 2024 12:32
@skyzh skyzh added the run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label label Dec 5, 2024
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added the run-benchmarks label so that we can run the benchmarks before merging the patch. Can you do a force push or add an empty commit to ensure it succeeds on CI before merging? Thanks :)

github-merge-queue bot pushed a commit that referenced this pull request Dec 6, 2024
#10013)

## Problem

I'm writing an ingest benchmark in #9812. To time S3 uploads, I need to
schedule a flush of the Pageserver's in-memory layer, but don't actually
want to wait around for it to complete (which will take a minute).

## Summary of changes

Add a parameter `wait_until_flush` (default `true`) for
`timeline/checkpoint` to control whether to wait for the flush to
complete.
Base automatically changed from erik/checkpoint-wait to main December 6, 2024 10:14
@github-actions github-actions bot requested a review from a team as a code owner December 6, 2024 10:14
@github-actions github-actions bot requested a review from jcsp December 6, 2024 10:14
@erikgrinaker erikgrinaker force-pushed the erik/benchmark-bulk-insert branch from 7a2cb90 to 7bf135b Compare December 6, 2024 10:37
@erikgrinaker erikgrinaker added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 14c4fae Dec 6, 2024
83 checks passed
@erikgrinaker erikgrinaker deleted the erik/benchmark-bulk-insert branch December 6, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants