-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_runner/performance: add improved bulk insert benchmark #9812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7190 tests run: 6871 passed, 0 failed, 319 skipped (full report)Flaky tests (2)Postgres 16
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
14e1e4b at 2024-12-06T16:18:20.498Z :recycle: |
erikgrinaker
force-pushed
the
erik/benchmark-bulk-insert
branch
2 times, most recently
from
November 25, 2024 15:14
34e8392
to
20b6afc
Compare
erikgrinaker
force-pushed
the
erik/benchmark-bulk-insert
branch
from
December 4, 2024 13:35
20b6afc
to
874c3fa
Compare
erikgrinaker
force-pushed
the
erik/benchmark-bulk-insert
branch
from
December 4, 2024 16:14
874c3fa
to
d05b3da
Compare
erikgrinaker
force-pushed
the
erik/benchmark-bulk-insert
branch
2 times, most recently
from
December 5, 2024 09:06
16bf5b7
to
7a2cb90
Compare
erikgrinaker
requested review from
a team and
skyzh
and removed request for
a team
December 5, 2024 12:32
skyzh
added
the
run-benchmarks
Indicates to the CI that benchmarks should be run for PR marked with this label
label
Dec 5, 2024
skyzh
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've added the run-benchmarks label so that we can run the benchmarks before merging the patch. Can you do a force push or add an empty commit to ensure it succeeds on CI before merging? Thanks :)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
#10013) ## Problem I'm writing an ingest benchmark in #9812. To time S3 uploads, I need to schedule a flush of the Pageserver's in-memory layer, but don't actually want to wait around for it to complete (which will take a minute). ## Summary of changes Add a parameter `wait_until_flush` (default `true`) for `timeline/checkpoint` to control whether to wait for the flush to complete.
erikgrinaker
force-pushed
the
erik/benchmark-bulk-insert
branch
from
December 6, 2024 10:37
7a2cb90
to
7bf135b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
run-benchmarks
Indicates to the CI that benchmarks should be run for PR marked with this label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an improved bulk insert benchmark, including S3 uploads.
Touches #9789.