Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: add wait_until_flushed parameter for timeline checkpoint #10013

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

erikgrinaker
Copy link
Contributor

Problem

I'm writing an ingest benchmark in #9812. To time S3 uploads, I need to schedule a flush of the Pageserver's in-memory layer, but don't actually want to wait around for it to complete (which will take a minute).

Summary of changes

Add a parameter wait_until_flush (default true) for timeline/checkpoint to control whether to wait for the flush to complete.

@erikgrinaker erikgrinaker requested a review from a team as a code owner December 4, 2024 16:12
@erikgrinaker erikgrinaker requested a review from arssher December 4, 2024 16:12
Copy link

github-actions bot commented Dec 4, 2024

7040 tests run: 6731 passed, 0 failed, 309 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 15

Code coverage* (full report)

  • functions: 31.4% (8324 of 26503 functions)
  • lines: 47.8% (65442 of 137029 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6d735cf at 2024-12-06T10:07:23.157Z :recycle:

@erikgrinaker erikgrinaker added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit ec4072f Dec 6, 2024
82 checks passed
@erikgrinaker erikgrinaker deleted the erik/checkpoint-wait branch December 6, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants