Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offloaded timeline deletion #9519

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Offloaded timeline deletion #9519

merged 3 commits into from
Oct 29, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Oct 25, 2024

As pointed out in #9489 (comment) , we currently didn't support deletion for offloaded timelines after the timeline has been loaded from the manifest instead of having been offloaded.

This was because the upload queue hasn't been initialized yet. This PR thus initializes the timeline and shuts it down immediately.

Part of #8088

@arpad-m arpad-m requested a review from a team as a code owner October 25, 2024 12:39
@arpad-m arpad-m requested a review from problame October 25, 2024 12:39
Copy link

github-actions bot commented Oct 25, 2024

5282 tests run: 5067 passed, 1 failed, 214 skipped (full report)


Failures on Postgres 17

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_sharding_split_failures[debug-pg17-failure15]"
Flaky tests (3)

Postgres 17

Code coverage* (full report)

  • functions: 31.4% (7697 of 24540 functions)
  • lines: 48.8% (60462 of 123841 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d418456 at 2024-10-26T13:34:26.111Z :recycle:

@problame problame removed their request for review October 29, 2024 10:06
@jcsp jcsp merged commit a73402e into main Oct 29, 2024
83 checks passed
@jcsp jcsp deleted the arpad/offloaded_timeline_deletion branch October 29, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants