-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support offloaded timelines during shard split #9489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpad-m
changed the title
Support offloaded timelines during shard splits of offloaded timelines
Support offloaded timelines during shard splits
Oct 23, 2024
arpad-m
changed the title
Support offloaded timelines during shard splits
Support offloaded timelines during shard split
Oct 23, 2024
5273 tests run: 5059 passed, 0 failed, 214 skipped (full report)Flaky tests (4)Postgres 17
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
7b558cc at 2024-10-24T15:06:38.557Z :recycle: |
jcsp
reviewed
Oct 24, 2024
jcsp
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct, but the way OffloadedTimeline::remote_client
is used is a bit tenuous & I think other stuff that uses it might not work (comment inline)
jcsp
approved these changes
Oct 24, 2024
jcsp
pushed a commit
that referenced
this pull request
Oct 29, 2024
As pointed out in #9489 (comment) , we currently didn't support deletion for offloaded timelines after the timeline has been loaded from the manifest instead of having been offloaded. This was because the upload queue hasn't been initialized yet. This PR thus initializes the timeline and shuts it down immediately. Part of #8088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we didn't copy over the
index-part.json
of offloaded timelines to the new shard's location, resulting in the new shard not knowing the timeline even exists.In #9444, we copy over the manifest, but we also need to do this for
index-part.json
.As the operations to do are mostly the same between offloaded and non-offloaded timelines, we can iterate over all of them in the same loop, after the introduction of a
TimelineOrOffloadedArcRef
type to generalize over the two cases. This is analogous to the deletion code added in #8907.The added test also ensures that the sharded archival config endpoint works, something that has not yet been ensured by tests.
Part of #8088