Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(per-tenant throttling): incorrect allowed_rps field in log message #6869

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

problame
Copy link
Contributor

@problame problame commented Feb 21, 2024

The refill_interval switched from a milliseconds usize to a Duration during a review follow-up, hence this slipped through manual testing.

Part of #5899

The `refill_interval` switched from a milliseconds usize to a Duration
during a review follow-up, hence this slipped through manual testing.
@problame problame requested a review from jcsp February 21, 2024 18:38
@problame problame requested a review from a team as a code owner February 21, 2024 18:38
Copy link

github-actions bot commented Feb 21, 2024

2466 tests run: 2345 passed, 0 failed, 121 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_remote_timeline_client_calls_started_metric: debug

Postgres 15

  • test_remote_storage_upload_queue_retries: debug
  • test_timeline_size: debug

Code coverage* (full report)

  • functions: 28.8% (6756 of 23462 functions)
  • lines: 47.6% (41077 of 86306 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
28359fb at 2024-02-22T08:42:44.216Z :recycle:

@problame problame merged commit c671aea into main Feb 22, 2024
50 checks passed
@problame problame deleted the problame/throttling-fix-steady-rps-method branch February 22, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants