Skip to content

Commit

Permalink
fix(per-tenant throttling): incorrect allowed_rps field in log mess…
Browse files Browse the repository at this point in the history
…age (#6869)

The `refill_interval` switched from a milliseconds usize to a Duration
during a review follow-up, hence this slipped through manual testing.

Part of #5899
  • Loading branch information
problame authored Feb 22, 2024
1 parent bc7a82c commit c671aea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion libs/pageserver_api/src/models.rs
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ impl ThrottleConfig {
}
/// The requests per second allowed by the given config.
pub fn steady_rps(&self) -> f64 {
(self.refill_amount.get() as f64) / (self.refill_interval.as_secs_f64()) / 1e3
(self.refill_amount.get() as f64) / (self.refill_interval.as_secs_f64())
}
}

Expand Down

1 comment on commit c671aea

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2541 tests run: 2405 passed, 1 failed, 135 skipped (full report)


Failures on Postgres 14

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_sql_regress[release-pg14-None]"

Test coverage report is not available

The comment gets automatically updated with the latest test results
c671aea at 2024-02-22T15:14:49.526Z :recycle:

Please sign in to comment.