Skip to content

Commit

Permalink
PostgreSQL minor version updates (17.1, 16.5, 15.9, 14.14) (#9727)
Browse files Browse the repository at this point in the history
This includes a patch to temporarily disable one test in the pg_anon
test suite. It is an upstream issue, the test started failing with the
new PostgreSQL minor versions because of a change in the default
timezone used in tests. We don't want to block the release for this,
so just disable the test for now. See
https://gitlab.com/dalibo/postgresql_anonymizer/-/commit/199f0a392b37c59d92ae441fb8f037e094a11a52#note_2148017485

Corresponding postgres repository PRs:
neondatabase/postgres#524
neondatabase/postgres#525
neondatabase/postgres#526
neondatabase/postgres#527
  • Loading branch information
hlinnaka authored Nov 13, 2024
1 parent d5435b1 commit 10aaa36
Show file tree
Hide file tree
Showing 6 changed files with 54 additions and 12 deletions.
42 changes: 42 additions & 0 deletions compute/patches/pg_anon.patch
Original file line number Diff line number Diff line change
@@ -1,3 +1,45 @@
commit 00aa659afc9c7336ab81036edec3017168aabf40
Author: Heikki Linnakangas <heikki@neon.tech>
Date: Tue Nov 12 16:59:19 2024 +0200

Temporarily disable test that depends on timezone

diff --git a/tests/expected/generalization.out b/tests/expected/generalization.out
index 23ef5fa..9e60deb 100644
--- a/ext-src/pg_anon-src/tests/expected/generalization.out
+++ b/ext-src/pg_anon-src/tests/expected/generalization.out
@@ -284,12 +284,9 @@ SELECT anon.generalize_tstzrange('19041107','century');
["Tue Jan 01 00:00:00 1901 PST","Mon Jan 01 00:00:00 2001 PST")
(1 row)

-SELECT anon.generalize_tstzrange('19041107','millennium');
- generalize_tstzrange
------------------------------------------------------------------
- ["Thu Jan 01 00:00:00 1001 PST","Mon Jan 01 00:00:00 2001 PST")
-(1 row)
-
+-- temporarily disabled, see:
+-- https://gitlab.com/dalibo/postgresql_anonymizer/-/commit/199f0a392b37c59d92ae441fb8f037e094a11a52#note_2148017485
+--SELECT anon.generalize_tstzrange('19041107','millennium');
-- generalize_daterange
SELECT anon.generalize_daterange('19041107');
generalize_daterange
diff --git a/tests/sql/generalization.sql b/tests/sql/generalization.sql
index b868344..b4fc977 100644
--- a/ext-src/pg_anon-src/tests/sql/generalization.sql
+++ b/ext-src/pg_anon-src/tests/sql/generalization.sql
@@ -61,7 +61,9 @@ SELECT anon.generalize_tstzrange('19041107','month');
SELECT anon.generalize_tstzrange('19041107','year');
SELECT anon.generalize_tstzrange('19041107','decade');
SELECT anon.generalize_tstzrange('19041107','century');
-SELECT anon.generalize_tstzrange('19041107','millennium');
+-- temporarily disabled, see:
+-- https://gitlab.com/dalibo/postgresql_anonymizer/-/commit/199f0a392b37c59d92ae441fb8f037e094a11a52#note_2148017485
+--SELECT anon.generalize_tstzrange('19041107','millennium');

-- generalize_daterange
SELECT anon.generalize_daterange('19041107');

commit 7dd414ee75f2875cffb1d6ba474df1f135a6fc6f
Author: Alexey Masterov <alexeymasterov@neon.tech>
Date: Fri May 31 06:34:26 2024 +0000
Expand Down
2 changes: 1 addition & 1 deletion vendor/postgres-v14
Submodule postgres-v14 updated 267 files
2 changes: 1 addition & 1 deletion vendor/postgres-v15
Submodule postgres-v15 updated 277 files
2 changes: 1 addition & 1 deletion vendor/postgres-v16
Submodule postgres-v16 updated 306 files
2 changes: 1 addition & 1 deletion vendor/postgres-v17
Submodule postgres-v17 updated 238 files
16 changes: 8 additions & 8 deletions vendor/revisions.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
{
"v17": [
"17.0",
"ae4cc30dba24f3910533e5a48e8103c3f2fff300"
"17.1",
"aa2e29f2b6952140dfe51876bbd11054acae776f"
],
"v16": [
"16.4",
"03b43900edc5d8d6eecec460bfc89aec7174bd84"
"16.5",
"b0b693ea298454e95e6b154780d1fd586a244dfd"
],
"v15": [
"15.8",
"fd631a959049dfe2b82f67409c8b8b0d3e0016d1"
"15.9",
"1feff6b60f07cb71b665d0f5ead71a4320a71743"
],
"v14": [
"14.13",
"de0a000dafc2e66ce2e39282d3aa1c704fe0390e"
"14.14",
"c5e0d642efb02e4bfedc283b0a7707fe6c79cc89"
]
}

1 comment on commit 10aaa36

@github-actions
Copy link

@github-actions github-actions bot commented on 10aaa36 Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5488 tests run: 5256 passed, 2 failed, 230 skipped (full report)


Failures on Postgres 16

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_sharded_ingest[release-pg16-github-actions-selfhosted-1] or test_compaction_l0_memory[release-pg16-github-actions-selfhosted]"

Code coverage* (full report)

  • functions: 31.8% (7889 of 24837 functions)
  • lines: 49.4% (62444 of 126292 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
10aaa36 at 2024-11-13T16:29:21.277Z :recycle:

Please sign in to comment.