Skip to content

Commit

Permalink
tests: Increase timeout in test_create_churn_during_restart (#9736)
Browse files Browse the repository at this point in the history
This test was seen to be flaky, e.g. at:
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9457/11804246485/index.html#suites/ec4311502db344eee91f1354e9dc839b/982bd121ea698414/.
If I _reduce_ the timeout from 10s to 8s on my laptop, it reliably hits
that timeout and fails. That suggests that the test is pretty close to
the edge even when it passes. Let's bump up the timeout to 30 s to make
it more robust.

See also #9730, although the
error message is different there.
  • Loading branch information
hlinnaka authored Nov 13, 2024
1 parent 080d585 commit d5435b1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test_runner/regress/test_tenants.py
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ def create_bg(delay_ms):
env.pageserver.start()

for f in futs:
f.result(timeout=10)
f.result(timeout=30)

# The tenant should end up active
wait_until_tenant_active(env.pageserver.http_client(), tenant_id, iterations=10, period=1)
Expand Down

1 comment on commit d5435b1

@github-actions
Copy link

@github-actions github-actions bot commented on d5435b1 Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5488 tests run: 5256 passed, 2 failed, 230 skipped (full report)


Failures on Postgres 16

  • test_sharded_ingest[github-actions-selfhosted-1]: release-x86-64
  • test_storage_controller_many_tenants[github-actions-selfhosted]: release-x86-64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_sharded_ingest[release-pg16-github-actions-selfhosted-1] or test_storage_controller_many_tenants[release-pg16-github-actions-selfhosted]"
Flaky tests (1)

Postgres 16

  • test_storage_controller_many_tenants[github-actions-selfhosted]: release-x86-64

Code coverage* (full report)

  • functions: 31.8% (7889 of 24837 functions)
  • lines: 49.4% (62440 of 126292 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d5435b1 at 2024-11-13T13:07:12.451Z :recycle:

Please sign in to comment.