Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Branch] Aggregation 6 #5945

Draft
wants to merge 53 commits into
base: dev
Choose a base branch
from
Draft

[Feature Branch] Aggregation 6 #5945

wants to merge 53 commits into from

Conversation

angrykoala
Copy link
Member

Description

This PR adds the new aggregate operations inside connections and deprecates the old aggregate operations

Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 5a3afbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@neo4j/graphql Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Feb 18, 2025

Performance Report

name dbHits old dbHits time (ms) old time (ms) maxRows
🟥 aggregations.TopLevelAggregateWithMultipleFields 9071 6802 93 80 1134
🟥 aggregations.NestedAggregation 23063 15407 112 94 2174
🟦 aggregations.TopLevelAggregateWithMultipleFieldsDeprecated 6802 N/A 49 N/A 1134
🟦 aggregations.NestedAggregationDeprecated 15407 N/A 54 N/A 2174
🟦 2871.NestedRelationshipFilter 19632 N/A 62 N/A 4395
🟦 2925.NestedSingleRelationshipFilter 17641 N/A 81 N/A 2174
🟦 2925.NestedSingleRelationshipRequiredFilter 9361 N/A 180 N/A 1040
🟦 query.OrFilterOnRelationshipsAndNested 26747 N/A 197 N/A 2027

🟥 - Performance worsened (dbHits)
🟩 - Performance improved (dbHits)
🟦 - New test

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3404 3404 39 54 1134
🟥 aggregations.TopLevelAggregateWithMultipleFields 9071 6802 93 80 1134
🟥 aggregations.NestedAggregation 23063 15407 112 94 2174
🟦 aggregations.TopLevelAggregateWithMultipleFieldsDeprecated 6802 N/A 49 N/A 1134
🟦 aggregations.NestedAggregationDeprecated 15407 N/A 54 N/A 2174
aggregations.AggregationWithWhere 10833 10833 41 72 2174
aggregations.AggregationWhereWithinNestedRelationships 20097917 20097917 2043 2353 2008534
aggregations.AggregationWhereWithinNestedConnections 20097917 20097917 2009 2071 2008534
aggregations.NestedCountFromMovieToActors 8603 8603 35 44 2174
aggregations.NestedCountFromActorsToMovie 8791 8791 43 49 2174
aggregations.DeeplyNestedCount 10052335 10052335 2357 2744 2008534
aggregations.InterfacesAggregations 6242 6242 49 57 2080
aggregations.InterfacesAggregationsWithTwoFields 11444 11444 168 99 2080
batch-create.BatchCreate 4200 4200 101 160 600
batch-create.BatchCreateSmall 77 77 63 63 11
connect.createAndConnect 6433 6433 134 173 3003
connections.Connection 12951 12951 70 77 2174
connections.NestedConnection 37705 37705 129 143 4516
create.SimpleMutation 7 7 66 65 1
cypher-directive.TopLevelMutationDirective 1135 1135 27 28 1134
delete.SimpleDelete 19401 19401 624 654 1040
🟦 2871.NestedRelationshipFilter 19632 N/A 62 N/A 4395
2925.SingleRelationshipFilter 5245 5245 39 59 1040
🟦 2925.NestedSingleRelationshipFilter 17641 N/A 81 N/A 2174
2925.SingleRelationshipRequiredFilter 5201 5201 78 45 1040
🟦 2925.NestedSingleRelationshipRequiredFilter 9361 N/A 180 N/A 1040
query.SimpleQuery 3121 3121 28 25 1040
query.SimpleQueryWithRelationship 15031 15031 45 49 2174
query.SimpleQueryWithNestedWhere 8713 8713 59 54 2154
query.Nested 10084891 10084891 6666 6801 2008534
query.NestedWithFilter 10064992 10064992 6542 6292 2004000
query.OrFilterOnRelationships 36946 36712 153 222 2027
🟦 query.OrFilterOnRelationshipsAndNested 26747 N/A 197 N/A 2027
query.QueryWithNestedIn 14468 14468 58 71 1956
query.NestedConnectionWhere 8703 8703 117 83 2174
query.DeeplyNestedConnectionWhere 8702 8702 77 107 2174
query.DeeplyNestedWithRelationshipFilters 17357 17357 126 178 1552
query.NestedWithRelationshipSingleFilters 3808 3808 152 226 1134
query.Fulltext 64 64 33 35 16
query.FulltextWithNestedQuery 516 516 42 48 84
sorting-and-cypher.TopLevelSortWithCypher 12961 12961 41 58 2174
sorting-and-cypher.TopLevelConnectionSortWithCypher 12961 12961 62 78 2174
sorting-and-cypher.TopLevelSortWithCypherWithNested 13096 13096 56 64 2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested 13096 13096 96 110 2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher 13720 13720 106 135 2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher 13266 13266 102 122 2174
sorting.SortMultipleTypes 3436 3436 90 108 1040
sorting.SortMultipleTypesWithCypherWithCypher 13321 13321 127 117 2174
sorting.SortOnNestedFields 12951 12951 61 52 2174
sorting.SortDeeplyNestedFields 39785 39785 101 102 4516
sorting.ConnectionWithSort 3271 3271 88 80 1040
unions.SimpleUnionQuery 321 321 55 64 35
unions.SimpleUnionQueryWithMissingFields 293 293 54 66 35
unions.NestedUnion 309975 309975 265 283 33033
unions.NestedUnionWithMissingFields 283949 283949 258 258 33033
update.NestedUpdate 14137 14137 99 111 2002

Old Schema Generation: 26.905s
Schema Generation: 30.257s
Old Subgraph Schema Generation: 28.701s
Subgraph Schema Generation: 29.769s

@angrykoala angrykoala changed the title Aggregation 6 [Feature Branch] Aggregation 6 Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants