Nested aggregations 6 #5993
Nested aggregations 6 #5993
Conversation
|
| const isTargetUnion = relationshipAdapter.target instanceof UnionEntityAdapter; | ||
| const isSourceInterface = relationshipAdapter.source instanceof InterfaceEntityAdapter; | ||
|
|
||
| if (relationshipAdapter.isAggregable() && !isTargetUnion && !isSourceInterface) { |
There was a problem hiding this comment.
I think the method isAggregable can hold the logic for isTargetUnion and isSourceInterface so that can be used a single source of truth
| fields["aggregate"] = `${relationshipAdapter.operations.getAggregationFieldTypename()}!`; | ||
| } | ||
|
|
||
| const connectionObjectType = composer.createObjectTC({ |
There was a problem hiding this comment.
Nitpick: you can create the objectTC first with the shared fields and then use the composer.addFields if needed for the aggregate field.
| const isSourceInterface = relationshipAdapter.source instanceof InterfaceEntityAdapter; | ||
|
|
||
| if (relationshipAdapter.isAggregable() && !isTargetUnion && !isSourceInterface) { | ||
| fields["aggregate"] = `${relationshipAdapter.operations.getAggregationFieldTypename()}!`; |
There was a problem hiding this comment.
| fields["aggregate"] = `${relationshipAdapter.operations.getAggregationFieldTypename()}!`; | |
| fields["aggregate"] = composer.getOTC(relationshipAdapter.operations.getAggregationFieldTypename()).NonNull; |
| } | ||
| const relationshipObjectType = composer.createObjectTC({ | ||
| name: typeName, | ||
| fields: { cursor: new GraphQLNonNull(GraphQLString), node: `${relationshipAdapter.target.name}!` }, |
There was a problem hiding this comment.
| fields: { cursor: new GraphQLNonNull(GraphQLString), node: `${relationshipAdapter.target.name}!` }, | |
| fields: { cursor: new GraphQLNonNull(GraphQLString), node: composer.getOTC(relationshipAdapter.target.name).NonNull }, |
| @@ -43,6 +43,7 @@ export class ConnectionAggregationField extends Field { | |||
| }) { | |||
| super(alias); | |||
| this.operation = operation; | |||
| this.operation.isInConnectionField = true; | |||
There was a problem hiding this comment.
If possible I would handle this in the factory rather than on the constructor
| typeDefs = ` | ||
| type ${typeMovie.name} @node { | ||
| title: String | ||
| ${typeActor.plural}: [${typeActor.name}!]! @relationship(type: "ACTED_IN", direction: IN, properties:"ActedIn") |
There was a problem hiding this comment.
| ${typeActor.plural}: [${typeActor.name}!]! @relationship(type: "ACTED_IN", direction: IN, properties:"ActedIn") | |
| actors: [${typeActor.name}!]! @relationship(type: "ACTED_IN", direction: IN, properties:"ActedIn") |
This is applicable also below
| typeDefs = ` | ||
| type ${typeMovie.name} @node { | ||
| title: String | ||
| ${typeActor.plural}: [${typeActor.name}!]! @relationship(type: "ACTED_IN", direction: IN, properties:"ActedIn") |
There was a problem hiding this comment.
| ${typeActor.plural}: [${typeActor.name}!]! @relationship(type: "ACTED_IN", direction: IN, properties:"ActedIn") | |
| actors: [${typeActor.name}!]! @relationship(type: "ACTED_IN", direction: IN, properties:"ActedIn") |
same below
Description
Support for nested aggregations inside connections