Cherry-pick add a new after-async or async phase to triggers #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ivangreene, I think the changes in this PR are already merged into the 4.1 branch. At least when I check TriggerHandler I can see most of the changes - https://github.com/neo4j-contrib/neo4j-apoc-procedures/blob/4.1/core/src/main/java/apoc/trigger/TriggerHandler.java Can you confirm? Cheers, Mark |
|
@mneedham yeah I cherry picked this commit from the 4.1 branch, but this PR is targeting 4.2. It looks like 4.2 and 4.3 branches were created from 4.1 before this change landed, so they never made it there: https://github.com/neo4j-contrib/neo4j-apoc-procedures/blob/4.2/core/src/main/java/apoc/trigger/TriggerHandler.java |
…ggers (neo4j-contrib#1573) * fixes neo4j-contrib#1547: Add a new after-async or async phase to triggers * Changed parameters to new syntax * Added "and thread" in afterAsync description Co-authored-by: Michael Hunger <github@jexp.de> Co-authored-by: Mark Needham <m.h.needham@gmail.com>
ivangreene
force-pushed
the
ig/afterasync
branch
from
4e7f93b to
eefd727
Compare
|
Just rebased to resolve the conflicts |
|
ah got it. That makes more sense! |
conker84
added a commit
to conker84/neo4j-apoc-procedures
that referenced
this pull request
Mar 29, 2021
…ggers (neo4j-contrib#1573) (neo4j-contrib#1735) * fixes neo4j-contrib#1547: Add a new after-async or async phase to triggers * Changed parameters to new syntax * Added "and thread" in afterAsync description Co-authored-by: Michael Hunger <github@jexp.de> Co-authored-by: Mark Needham <m.h.needham@gmail.com> Co-authored-by: Andrea Santurbano <santand@gmail.com> Co-authored-by: Michael Hunger <github@jexp.de> Co-authored-by: Mark Needham <m.h.needham@gmail.com>
conker84
added a commit
that referenced
this pull request
Apr 12, 2021
…#1735) * fixes #1547: Add a new after-async or async phase to triggers * Changed parameters to new syntax * Added "and thread" in afterAsync description Co-authored-by: Michael Hunger <github@jexp.de> Co-authored-by: Mark Needham <m.h.needham@gmail.com> Co-authored-by: Andrea Santurbano <santand@gmail.com> Co-authored-by: Michael Hunger <github@jexp.de> Co-authored-by: Mark Needham <m.h.needham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1731
Just cherry picked the commit from #1573 and resolved the conflicts
Proposed Changes (Mandatory)
A brief list of proposed changes in order to fix the issue: