fixes #1547: Add a new after-async or async phase to triggers #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, what do you think @jexp I think we need to add something more to the documentation advising users when they should be used the |
jexp
reviewed
Jul 14, 2020
| | before | The trigger will be activate right `before` the commit. If no phase is specified, it's the default. | ||
| | rollback | The trigger will be activate right after the `rollback` | ||
| | after | The trigger will be activate right `after` the commit | ||
| | afterAsync | The trigger will be activate right `after` the commit and inside a new transaction that will not |
jexp
reviewed
Jul 14, 2020
| @@ -15,7 +15,9 @@ Enable `apoc.trigger.enabled=true` in `$NEO4J_HOME/conf/apoc.conf` first. | |||
|
|
|||
| [cols="1m,5"] | |||
| |=== | |||
| | CALL apoc.trigger.add(name, statement, selector) yield name, statement, installed | add a trigger statement under a name, in the statement you can use {createdNodes}, {deletedNodes} etc., the selector is {phase:'before/after/rollback'} returns previous and new trigger information | |||
| | CALL apoc.trigger.add(name, statement, selector) yield name, statement, installed | add a trigger statement under a name, | |||
| in the statement you can use {createdNodes}, {deletedNodes} etc., the selector is {phase:'before/after/rollback/afterAsync'} | |||
There was a problem hiding this comment.
change syntax to $createdNodes etc.
jexp
approved these changes
Jul 14, 2020
|
Looks good to me, please merge and forward merge. |
mneedham
added a commit
that referenced
this pull request
Jul 20, 2020
* fixes #1547: Add a new after-async or async phase to triggers * Changed parameters to new syntax * Added "and thread" in afterAsync description Co-authored-by: Michael Hunger <github@jexp.de> Co-authored-by: Mark Needham <m.h.needham@gmail.com>
ivangreene
pushed a commit
to INNOSOLProject/neo4j-apoc-procedures
that referenced
this pull request
Dec 1, 2020
…ggers (neo4j-contrib#1573) * fixes neo4j-contrib#1547: Add a new after-async or async phase to triggers * Changed parameters to new syntax * Added "and thread" in afterAsync description Co-authored-by: Michael Hunger <github@jexp.de> Co-authored-by: Mark Needham <m.h.needham@gmail.com>
ivangreene
pushed a commit
to INNOSOLProject/neo4j-apoc-procedures
that referenced
this pull request
Dec 4, 2020
…ggers (neo4j-contrib#1573) * fixes neo4j-contrib#1547: Add a new after-async or async phase to triggers * Changed parameters to new syntax * Added "and thread" in afterAsync description Co-authored-by: Michael Hunger <github@jexp.de> Co-authored-by: Mark Needham <m.h.needham@gmail.com>
mneedham
added a commit
that referenced
this pull request
Dec 4, 2020
…#1735) * fixes #1547: Add a new after-async or async phase to triggers * Changed parameters to new syntax * Added "and thread" in afterAsync description Co-authored-by: Michael Hunger <github@jexp.de> Co-authored-by: Mark Needham <m.h.needham@gmail.com> Co-authored-by: Andrea Santurbano <santand@gmail.com> Co-authored-by: Michael Hunger <github@jexp.de> Co-authored-by: Mark Needham <m.h.needham@gmail.com>
conker84
added a commit
to conker84/neo4j-apoc-procedures
that referenced
this pull request
Mar 29, 2021
…ggers (neo4j-contrib#1573) (neo4j-contrib#1735) * fixes neo4j-contrib#1547: Add a new after-async or async phase to triggers * Changed parameters to new syntax * Added "and thread" in afterAsync description Co-authored-by: Michael Hunger <github@jexp.de> Co-authored-by: Mark Needham <m.h.needham@gmail.com> Co-authored-by: Andrea Santurbano <santand@gmail.com> Co-authored-by: Michael Hunger <github@jexp.de> Co-authored-by: Mark Needham <m.h.needham@gmail.com>
conker84
added a commit
that referenced
this pull request
Apr 12, 2021
…#1735) * fixes #1547: Add a new after-async or async phase to triggers * Changed parameters to new syntax * Added "and thread" in afterAsync description Co-authored-by: Michael Hunger <github@jexp.de> Co-authored-by: Mark Needham <m.h.needham@gmail.com> Co-authored-by: Andrea Santurbano <santand@gmail.com> Co-authored-by: Michael Hunger <github@jexp.de> Co-authored-by: Mark Needham <m.h.needham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1547
Added the
afterAsyncphaseProposed Changes (Mandatory)
A brief list of proposed changes in order to fix the issue:
afterAsyncphase