feat: time wasmer deserialization costs #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
changed the title
As that's where we spend the bulk of our time
There was a problem hiding this comment.
@matklad I thought we agreed to use debug_span! instead of info_span!
ailisp
approved these changes
Mar 9, 2021
|
@bowenwang1996 yeah, we should change this, but in a separate PR. At the moment the rest of vm-runner is using info, so I'd rather merge this and change to debug later. We don't enable logging for vm-runner on master anyway, so this shouldn't affect actual log output I think (#4038 is not merged) |
|
ok, let me merge this (there's a bunch of info calls anyway, so this doesn't make the things worse), and I'll immediatelly send a follow up to switch to debug. Follow up: #4069 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As that's where we spend the bulk of our time