feat: improve visibility for runtime performance #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
approved these changes
Mar 5, 2021
olonho
approved these changes
Mar 13, 2021
|
This PR has been automatically marked as stale because it has not had recent activity in the 2 weeks. |
|
@matklad please resolve the merge conflict and fix CI :) |
tracing::span records how long it took to run a block of code and prints this into into log. See https://github.com/near/nearcore/blob/ff01c544ce2675fadbf0284af52b356a383b27a8/docs/architecture.md#runtimenear-vm-runner for the info on the tracing infra
|
Rebased, applying auto merge as I don't think anything changed here. cc @near/nodex (@bowenwang1996, should we create this team alias for GH pings?), I think we might want more of this throughout the stack! |
|
The issue for "have more of this" is #4040 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracing::span records how long it took to run a block of code and prints
this into into log.
See
https://github.com/near/nearcore/blob/ff01c544ce2675fadbf0284af52b356a383b27a8/docs/architecture.md#runtimenear-vm-runner
for the info on the tracing infra
Test Plan
Only active with debug logging level enabled, doesn't need additional testing.