Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated RPC fields #2271

Open
3 tasks
ilblackdragon opened this issue Mar 18, 2020 · 10 comments
Open
3 tasks

Deprecated RPC fields #2271

ilblackdragon opened this issue Mar 18, 2020 · 10 comments
Labels
A-RPC Area: rpc T-public-interfaces Team: issues relevant to the public interfaces team
Milestone
Post MainNet

Comments

@ilblackdragon
Copy link
Member

ilblackdragon commented Mar 18, 2020 •
edited by exalate-issue-sync bot
Loading

This issue tracks all deprecated fields in the RPC. Remove next fields after all of the app layer have updated and appropriate timeframe.

Deprecation as of March 18, 2020 conditioned on #2272 :

  • AccountView.storage_paid_at
  • BlockHeaderView.rent_paid
  • ChunkHeaderView.rent_paid
@ilblackdragon ilblackdragon added the A-RPC Area: rpc label Mar 18, 2020
@ilblackdragon ilblackdragon added this to the Post MainNet milestone Mar 18, 2020
@frol
Copy link
Collaborator

frol commented Mar 18, 2020 •
edited
Loading

@ilblackdragon Why those are deprecated? I find AccountView.storage_paid_at useful to learn the last time the account has been touched... Well, it is not immediately clear that one can use it this way, so we may want to have a better name for it, but I wonder what made these fields deprecated and are there replacements.

Answer: Due to #2272

This was referenced Mar 27, 2020
Merged
Merged
frol added a commit to near/near-explorer that referenced this issue Mar 30, 2020
@frol
feature: Removed the deprecated storage_paid_at field (#241)
7faec76 
As per the switch from State renting to State staking, storage_paid_at is no longer useful. Thus, removing it from the UI. near/nearcore#2271

## Test Plan

* No extra tests are needed.
@frol frol mentioned this issue Apr 8, 2020
Merged
@stale
Copy link

stale bot commented Jul 1, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Jul 1, 2021
@bowenwang1996 bowenwang1996 added the T-public-interfaces Team: issues relevant to the public interfaces team label Jul 2, 2021
@stale stale bot removed the S-stale label Jul 2, 2021
@bowenwang1996
Copy link
Collaborator

@frol what is the status of this issue?

@frol
Copy link
Collaborator

frol commented Aug 9, 2021

The fields has been serving empty values for quite a while, so nobody would use them. We should just remove the fields.

@leoyvens leoyvens mentioned this issue Oct 6, 2021
Merged
@stale
Copy link

stale bot commented Nov 7, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Nov 7, 2021
@bowenwang1996
Copy link
Collaborator

@frol is anyone working on this?

@stale stale bot removed the S-stale label Nov 8, 2021
@frol
Copy link
Collaborator

frol commented Nov 23, 2021

@bowenwang1996 it is not part of our priority for this quarter

@stale
Copy link

stale bot commented Feb 21, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Feb 21, 2022
@stale
Copy link

stale bot commented May 23, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label May 23, 2022
@frol frol removed their assignment May 24, 2022
@stale stale bot removed the S-stale label May 24, 2022
@frol
Copy link
Collaborator

frol commented May 24, 2022

It will be much easier to address after #6850 and #5516 are addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-RPC Area: rpc T-public-interfaces Team: issues relevant to the public interfaces team
Projects
None yet
Milestone
Post MainNet
Development

No branches or pull requests
3 participants
@ilblackdragon @frol @bowenwang1996