NEAR support #210

evaporei · 2021-09-24T19:39:53Z

Ready for review, 🚨 don't merge 🚨 .

Based of the Receipt of this proto file.

We probably will address the TODO comments once the .proto file is up to date (which will require changes in multiple projects/repos, so that's for the end).

Solves: https://github.com/graphprotocol/graph-ts/issues/209

leoyvens · 2021-09-30T14:13:22Z

Nice! One thing I think is worth adding already on this first pass the Block type, as a block: Block field in ReceiptWithOutcome, because it is very common to need at least basic info like block hash and number. And we'll need it anyways for block triggers. It can be a direct translation of the Block message https://github.com/streamingfast/proto-near/blob/develop/sf/near/codec/v1/codec.proto#L95.

chain/near.ts

maoueh · 2021-10-13T05:13:27Z

chain/near.ts

+
+  export class AccessKeyPermissionValue {
+    constructor(
+      public kind: AccessPermissionKind,


AccessPermissionKind is not defined anywhere.

Suggested change

public kind: AccessPermissionKind,

public kind: AccessKeyPermissionKind,

?

You're correct, just fixed the typo, thanks!

maoueh · 2021-10-13T05:15:05Z

chain/near.ts

+
+  export class ExecutionOutcome {
+    constructor(
+      public proof: MerklePath,


MerklePath is not defined anywhere

Added! Nice catch 🙂

chain/near.ts

evaporei · 2021-10-13T12:55:06Z

@maoueh thanks for the review! Still, two of your comments should've been caught by the CI, I'll investigate why it didn't failed compiling near.ts.

Edit: I've added a build step to the CI so that errors like these are caught early. I'm still not 100% sure why the tests didn't have a compilation error, but I guess it's a compiler optimization to remove dead code from the asc (AS compiler) side.

This is needed because of the `class MerklePath extends Array<MerklePathItem`. The same had to be done for `Tuple` and `Value` in the `ethereum` file/module. AssemblyScript requires those implementations because of the super class.

maoueh · 2021-10-13T19:17:07Z

@otaviopace Missing pieces for global.ts

  ...
  ArrayF64 = 50,
  ArrayBigDecimal = 51,

  // NEAR
  NearSignature = 52,
  NearPublicKey = 53,
  NearFunctionCallPermission = 54,
  NearFullAccessPermission = 55,
  NearAccessKeyPermissionValue = 56,
  NearAccessKey = 57,
  NearDataReceiver = 58,
  NearCreateAccountAction = 59,
  NearDeployContractAction = 60,
  NearFunctionCallAction = 61,
  NearTransferAction = 62,
  NearStakeAction = 63,
  NearAddKeyAction = 64,
  NearDeleteKeyAction = 65,
  NearDeleteAccountAction = 66,
  NearActionValue = 67,
  NearActionReceipt = 68,
  NearSuccessStatus = 69,
  NearMerklePath = 70,
  NearExecutionOutcome = 71,
  NearSlashedValidator = 72,
  NearBlockHeader = 73,
  NearValidatorStake = 74,
  NearChunkHeader = 75,
  NearBlock = 76,
  NearReceiptWithOutcome = 77,

    ...
    case TypeId.ArrayF64:
      return idof<Array<f64>>()
    case TypeId.ArrayBigDecimal:
      return idof<Array<BigDecimal>>()

    // NEAR
    case TypeId.NearSignature:
      return idof<NearSignature>()
    case TypeId.NearPublicKey:
      return idof<NearPublicKey>()
    case TypeId.NearFunctionCallPermission:
      return idof<NearFunctionCallPermission>()
    case TypeId.NearFullAccessPermission:
      return idof<NearFullAccessPermission>()
    case TypeId.NearAccessKeyPermissionValue:
      return idof<NearAccessKeyPermissionValue>()
    case TypeId.NearAccessKey:
      return idof<NearAccessKey>()
    case TypeId.NearDataReceiver:
      return idof<NearDataReceiver>()
    case TypeId.NearCreateAccountAction:
      return idof<NearCreateAccountAction>()
    case TypeId.NearDeployContractAction:
      return idof<NearDeployContractAction>()
    case TypeId.NearFunctionCallAction:
      return idof<NearFunctionCallAction>()
    case TypeId.NearTransferAction:
      return idof<NearTransferAction>()
    case TypeId.NearStakeAction:
      return idof<NearStakeAction>()
    case TypeId.NearAddKeyAction:
      return idof<NearAddKeyAction>()
    case TypeId.NearDeleteKeyAction:
      return idof<NearDeleteKeyAction>()
    case TypeId.NearDeleteAccountAction:
      return idof<NearDeleteAccountAction>()
    case TypeId.NearActionValue:
      return idof<NearActionValue>()
    case TypeId.NearActionReceipt:
      return idof<NearActionReceipt>()
    case TypeId.NearSuccessStatus:
      return idof<NearSuccessStatus>()
    case TypeId.NearMerklePath:
      return idof<NearMerklePath>()
    case TypeId.NearExecutionOutcome:
      return idof<NearExecutionOutcome>()
    case TypeId.NearSlashedValidator:
      return idof<NearSlashedValidator>()
    case TypeId.NearBlockHeader:
      return idof<NearBlockHeader>()
    case TypeId.NearValidatorStake:
      return idof<NearValidatorStake>()
    case TypeId.NearChunkHeader:
      return idof<NearChunkHeader>()
    case TypeId.NearBlock:
      return idof<NearBlock>()
    case TypeId.NearReceiptWithOutcome:
      return idof<NearReceiptWithOutcome>()
      
    default:
      return 0
  }

chain/near.ts

maoueh · 2021-10-14T21:40:48Z

chain/near.ts

+    }
+  }
+
+  export class MerklePath extends Array<MerklePathItem> {}


Could we actually get rid of MerklePath here, I'm not seeing the added benefits of having it. Maybe there is something else in play that I do not see.

Do you want to remove the proof field from the ExecutionOutcome class entirely? It seems to be the only place that uses it.

In fact, I'm wondering what is the correct Rust bindings for this one, is it AscPtr<AscMerklePath> or directly AscPtr<Array<AsckMerklePathItem>>?

I think we want to have the first one because it will be a new class, and that requires a new class identifier for the header.

I'll still wondering how such "extended" array should look like when generating the underlying AscMerklePath here. How to represent the "extends" fact. Will need you help to determine the correct mapping.

chain/near.ts

maoueh

Left two more review comments.

chain/near.ts

maoueh · 2021-10-21T23:19:47Z

chain/near.ts

+      public outcomeRoot: CryptoHash,
+      public chunksIncluded: u64,
+      public challengesRoot: CryptoHash,
+      public timestampNanosec: u64,


I think the timestamp is missing, this is, AFAIK, only the nano sec of the timestamp so it kind of add up to the timestamp value in milliseconds (also to be validated) and adds extra precision.

We have the timestamp in the protobuf.

I didn't add because it's deprecated, as shown here: https://docs.rs/near-primitives/0.1.0-pre.1/near_primitives/views/struct.BlockHeaderView.html#structfield.timestamp

maoueh · 2021-10-21T23:20:53Z

And we need to update for the latest IndexTypeId global things.

The `test` script was not catching these for some reason that's probably related to how the AssemblyScript compiles code and removes unnecessary things (needs further investigation). For now it's very much helpful (and needed) to catch compilation errors on the CI step.

evaporei self-assigned this Sep 24, 2021

evaporei force-pushed the otavio/near branch 3 times, most recently from 06b026c to e5e6e8e Compare September 27, 2021 22:47

evaporei changed the title ~~WIP - NEAR support~~ NEAR support Sep 27, 2021

evaporei marked this pull request as ready for review September 27, 2021 22:50

evaporei requested a review from leoyvens September 27, 2021 22:50

evaporei force-pushed the otavio/near branch from e5e6e8e to 29ad5b4 Compare September 30, 2021 04:45

near: Add base types and methods

1dea703

evaporei force-pushed the otavio/near branch from 29ad5b4 to 1dea703 Compare October 6, 2021 05:07

leoyvens suggested changes Oct 6, 2021

View reviewed changes

chore: Review fixes

948fac4

evaporei force-pushed the otavio/near branch from 90185b5 to 948fac4 Compare October 6, 2021 16:41

leoyvens approved these changes Oct 11, 2021

View reviewed changes

maoueh reviewed Oct 13, 2021

View reviewed changes

chain/near.ts Outdated Show resolved Hide resolved

maoueh reviewed Oct 13, 2021

View reviewed changes

chain/near.ts Show resolved Hide resolved

evaporei added 2 commits October 13, 2021 09:35

near: Fix permission typo

69fc657

near: Add missing MerklePath

0a16624

evaporei added 2 commits October 13, 2021 10:18

near: Fix another permission typo

73635bf

near: Add missing implementations for MerklePathItem

bb65f72

This is needed because of the `class MerklePath extends Array<MerklePathItem`. The same had to be done for `Tuple` and `Value` in the `ethereum` file/module. AssemblyScript requires those implementations because of the super class.

maoueh reviewed Oct 14, 2021

View reviewed changes

chain/near.ts Outdated Show resolved Hide resolved

maoueh reviewed Oct 14, 2021

View reviewed changes

maoueh reviewed Oct 16, 2021

View reviewed changes

chain/near.ts Outdated Show resolved Hide resolved

maoueh reviewed Oct 16, 2021

View reviewed changes

chain/near.ts Outdated Show resolved Hide resolved

maoueh suggested changes Oct 21, 2021

View reviewed changes

evaporei and others added 4 commits October 22, 2021 09:07

near: Change some fields from 'string' to 'bytes'

4c753d7

global: Add near TypeIds

92e9f02

Re-order fields to fix alignment issue

22312fd

evaporei force-pushed the otavio/near branch from dea0160 to 22312fd Compare October 22, 2021 12:08

evaporei added 2 commits October 22, 2021 09:12

near: AccountId -> Account

4e9d46c

near: Fix global type ids

1ed9aec

evaporei merged commit f5d7ebd into master Oct 22, 2021

evaporei deleted the otavio/near branch October 22, 2021 17:22

evaporei mentioned this pull request Oct 26, 2021

0.23.0 #222

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NEAR support #210

NEAR support #210

evaporei commented Sep 24, 2021 •

edited

Loading

leoyvens commented Sep 30, 2021

maoueh Oct 13, 2021

evaporei Oct 13, 2021

maoueh Oct 13, 2021

evaporei Oct 13, 2021

evaporei commented Oct 13, 2021 •

edited

Loading

maoueh commented Oct 13, 2021

maoueh Oct 14, 2021

evaporei Oct 14, 2021

maoueh Oct 15, 2021

evaporei Oct 15, 2021

maoueh Oct 16, 2021

maoueh left a comment

maoueh Oct 21, 2021

evaporei Oct 22, 2021

maoueh commented Oct 21, 2021

	public kind: AccessPermissionKind,
	public kind: AccessKeyPermissionKind,

NEAR support #210

NEAR support #210

Conversation

evaporei commented Sep 24, 2021 • edited Loading

leoyvens commented Sep 30, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evaporei commented Oct 13, 2021 • edited Loading

maoueh commented Oct 13, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maoueh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maoueh commented Oct 21, 2021

evaporei commented Sep 24, 2021 •

edited

Loading

evaporei commented Oct 13, 2021 •

edited

Loading