Skip to content

Commit

Permalink
fix: Ensure surefire-action-report for nightly only runs on main (dee…
Browse files Browse the repository at this point in the history
…phaven#6274)

This fixes the errors currently observed due to the introduction of
deephaven#6269 by making sure the step only runs on the main branch. For example,
https://github.com/deephaven/deephaven-core/actions/runs/11485054757/job/31964249592
has the following log

```
Going to parse results form **/build/test-results/*/TEST-*.xml
Result: 9648 tests run, 37 skipped, 0 failed.
Posting status 'completed' with conclusion 'success' to refs/heads/dependabot/gradle/io.airlift-aircompressor-2.0.2 (sha: 7ab48f9)
Error: Resource not accessible by integration
```

In this case, action-surefire-report is trying to report against a SHA
owned by the dependabot branch.
  • Loading branch information
devinrsmith authored Oct 23, 2024
1 parent 1635218 commit 306153a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/nightly-check-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:

- name: Publish Test Results
uses: scacap/action-surefire-report@v1
if: ${{ github.repository_owner == 'deephaven' }}
if: ${{ github.repository_owner == 'deephaven' && github.ref == 'refs/heads/main' }}
env:
NODE_OPTIONS: '--max_old_space_size=4096'
with:
Expand Down

0 comments on commit 306153a

Please sign in to comment.