fix: Ensure surefire-action-report for nightly only runs on main #6274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the errors currently observed due to the introduction of deephaven#6269 by making sure the step only runs on the main branch. For example, https://github.com/deephaven/deephaven-core/actions/runs/11485054757/job/31964249592 has the following log ``` Going to parse results form **/build/test-results/*/TEST-*.xml Result: 9648 tests run, 37 skipped, 0 failed. Posting status 'completed' with conclusion 'success' to refs/heads/dependabot/gradle/io.airlift-aircompressor-2.0.2 (sha: 7ab48f9) Error: Resource not accessible by integration ``` In this case, action-surefire-report is trying to report against a SHA owned by the dependabot branch.
devinrsmith
added
ci
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
requested review from
jcferretti,
JamesXNelson,
mofojed and
rcaudy
as code owners
rcaudy
approved these changes
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the errors currently observed due to the introduction of #6269 by making sure the step only runs on the main branch. For example, https://github.com/deephaven/deephaven-core/actions/runs/11485054757/job/31964249592 has the following log
In this case, action-surefire-report is trying to report against a SHA owned by the dependabot branch.