Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issues in ACI integration #486

Merged
merged 28 commits into from
Aug 21, 2024
Merged

Fixing issues in ACI integration #486

merged 28 commits into from
Aug 21, 2024

Conversation

mzbroch
Copy link
Contributor

@mzbroch mzbroch commented Jul 25, 2024 •
edited by jdrew82
Loading

This PR implements #491

  • Several sync issues fixed
  • Performance optimisation for get bridge domain functions
  • Prevent from importing discrepancy data from ACI (bridge domains missing a VRF will not be loaded)
  • MSite tag

TODO:

  • sync main to develop in this project

@mzbroch mzbroch requested review from chadell and a team as code owners July 25, 2024 11:30
jdrew82
jdrew82 requested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things but good start.

nautobot_ssot/integrations/aci/jobs.py Outdated Show resolved Hide resolved
nautobot_ssot/integrations/aci/diffsync/adapters/aci.py Outdated Show resolved Hide resolved
@jdrew82 jdrew82 mentioned this pull request Jul 25, 2024
Closed
@mzbroch mzbroch changed the title [WIP] Fixing issues in ACI integration Fixing issues in ACI integration Jul 26, 2024
@mzbroch mzbroch requested a review from jdrew82 July 31, 2024 07:17
@jdrew82
Copy link
Contributor

jdrew82 commented Aug 14, 2024

@mzbroch can you rebase this now that we have main sync'd with develop?

jdrew82
jdrew82 requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things to address.

nautobot_ssot/integrations/aci/diffsync/client.py Outdated Show resolved Hide resolved
nautobot_ssot/integrations/aci/diffsync/client.py Outdated Show resolved Hide resolved
nautobot_ssot/integrations/aci/diffsync/client.py Outdated Show resolved Hide resolved
nautobot_ssot/integrations/aci/jobs.py Outdated Show resolved Hide resolved
nautobot_ssot/tests/aci/test_api.py Outdated Show resolved Hide resolved
@jdrew82 jdrew82 linked an issue Aug 21, 2024 that may be closed by this pull request
[ACI Integration] Improve sync behaviour #491
Closed
@jdrew82 jdrew82 added the type: bug Issues/PRs addressing a bug. label Aug 21, 2024
@jdrew82 jdrew82 added the integration: ciscoaci Issues/PRs for Cisco ACI integration. label Aug 21, 2024
jdrew82
jdrew82 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the suggested changes as @mzbroch is on PTO.

@jdrew82 jdrew82 merged commit e3b9dbe into develop Aug 21, 2024
16 checks passed
@jdrew82 jdrew82 deleted the pvillar-aci-ssot-WIP-mzb branch August 21, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrew82 jdrew82 jdrew82 approved these changes

@pato23arg pato23arg pato23arg approved these changes

@chadell chadell Awaiting requested review from chadell chadell is a code owner

Assignees

@mzbroch mzbroch

Labels
integration: ciscoaci Issues/PRs for Cisco ACI integration. type: bug Issues/PRs addressing a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ACI Integration] Improve sync behaviour
3 participants
@mzbroch @jdrew82 @pato23arg