Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job Cisco ACI Data Source Fail with error KeyError: 'vrf' #485

Closed
Cymmus opened this issue Jul 24, 2024 · 2 comments
Closed

Job Cisco ACI Data Source Fail with error KeyError: 'vrf' #485

Cymmus opened this issue Jul 24, 2024 · 2 comments
Labels
integration: ciscoaci Issues/PRs for Cisco ACI integration. type: bug Issues/PRs addressing a bug.

Comments

@Cymmus
Copy link

Cymmus commented Jul 24, 2024

Environment

  • Python version: 3.11.9
  • Nautobot version: 2.2.3
  • nautobot-ssot version: 2.6.1

Expected Behavior

Job should work properly and sync information from ACI

Observed Behavior

Job failed with error KeyError: 'vrf'

Steps to Reproduce

I have nautobot in a container with the following config for the Ssot plugin:

PLUGINS_CONFIG = {
    "nautobot_ssot": {
        # Enable Cisco ACI integration
        "enable_aci": True,
        # URL and credentials should be configured as environment variables on the host system
        "aci_apics": {x: os.environ[x] for x in os.environ if "APIC" in x},
        # Tag which will be created and applied to all synchronized objects.
        "aci_tag": "ACI",
        # Manufacturer name. Specify existing, or a new one with this name will be created.
        "aci_manufacturer_name": "Cisco",
        # Exclude any tenants you would not like to bring over from ACI.
        "aci_ignore_tenants": ["mgmt", "infra"],
        # The below value will appear in the Comments field on objects created in Nautobot
        "aci_comments": "Created by ACI SSoT Integration",
     }
}

But when the job try to sync the BridgeDomain/Prefixes it failed to do so because the tenant mgmt is not correctly ignored.

In the file nautobot_ssot/integrations/aci/diffsync/adapters/aci at line 258 (branch develop) the "if" condition to check the tenant that should be ignore is not working properly.

the variable "tenant_name" at line 253 include the tenant_prefix wich make the condition at line 258 irrelevant.

@jdrew82
Copy link
Contributor

jdrew82 commented Jul 25, 2024

This might be addressed with #486

@jdrew82 jdrew82 added type: bug Issues/PRs addressing a bug. integration: ciscoaci Issues/PRs for Cisco ACI integration. labels Jul 25, 2024
@jdrew82
Copy link
Contributor

jdrew82 commented Aug 23, 2024

@Cymmus I'm going to assume this issue has been resolved with #486. We can reopen it if the issue persists.

@jdrew82 jdrew82 closed this as completed Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: ciscoaci Issues/PRs for Cisco ACI integration. type: bug Issues/PRs addressing a bug.
Projects
None yet
Development

No branches or pull requests

2 participants