Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed unclosed tmp file handle in filestore.go #6390

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fixed unclosed tmp file handle in filestore.go #6390

merged 1 commit into from
Jan 21, 2025

Conversation

deem0n
Copy link
Contributor

@deem0n deem0n commented Jan 21, 2025

Static analyzer found unclosed filehandle tmpFD in case of errors. It is not strictly necessary as GC will eventually close tmpFD, but explicit call of Close is always better than magic finalizer.

Based on the SO discussion

Signed-off-by: Dmitry Dorofeev dima@yasp.com

@deem0n
fixed unclosed tmp file handle in filestore.go
ebb84ae 
Signed-off-by: Dmitry Dorofeev <dima@yasp.com>
@deem0n deem0n requested a review from a team as a code owner January 21, 2025 12:42
@deem0n deem0n mentioned this pull request Jan 21, 2025
Closed
neilalexander
neilalexander approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@derekcollison derekcollison merged commit 7c25ec0 into nats-io:main Jan 21, 2025
2 checks passed
@neilalexander neilalexander mentioned this pull request Jan 22, 2025
Merged
neilalexander added a commit that referenced this pull request Jan 22, 2025
@neilalexander
Cherry-picks for 2.10.25-RC.3 (#6384)
d198cac 
Includes the following:

- #6373
- #6377
- #6379
- #6390
- #6392
- #6387
- #6292

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deem0n @neilalexander @derekcollison