[FIXED] Consumer stuck/slowdown during leader changes or redeliveries #6387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/consumer-redelivery-stuck
branch
from
86dcd36 to
090fd64
Compare
neilalexander
added a commit
that referenced
this pull request
Jan 22, 2025
derekcollison
added a commit
that referenced
this pull request
Jan 23, 2025
#6399) Follow-up of #6387 Deleting from `o.pending` and `o.rdc` in `o.getNextMsg` was a correctness issue. Due to us calling `go o.processTerm` we could go into `o.getNextMsg` before `o.processTerm` has adjusted the accounting for the message that's deleted. So we must not change `o.pending/o.rdc` ourselves, and we can just skip, waiting for `o.processTerm` to run. Resolves #6374 Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains two fixes:
o.awlis incremented and the message is pushed intoo.ackMsgs. However, if the consumer leader steps down (witho.setLeader(false)),o.ackMsgs.drain()is called, buto.awlis not reset. This results in a stuck consumer that can't redeliver messages due too.checkPendingshort-circuiting ono.awlbeing set.Resolves #6374
Signed-off-by: Maurice van Veen github@mauricevanveen.com