Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant use of IDisposable and ManualResetEvent. #262

Closed
wants to merge 1 commit into from
Closed

Conversation

Hellevar
Copy link

Fixed problem with usage of ManualResetEvent object.
original issue
As i can see there is no any reason to implement IDisposable and use ManualResetEvent inside Dispose method. With this fix everything works as expected.

@natemcmaster
Copy link
Owner

The purpose of implementing IDisposable and using a MRE is to ensure that services which might need to do some cleanup have a chance to gracefully exit before the process dies. While this might fix the ObjectDisposedException, it also removes one of the intentional features of this code.

Closing in favor of 38a5c76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants