2.4.0-beta.81 throws an ObjectDisposedException sometimes

[LordMike]

Describe the bug

I needed Ctrl-C support, so I was happy to find that the latest beta had just gotten that feature. But now I'm seeing an ObjectDisposedException - but only when running without a debugger. While debugging, I see nothing.

To Reproduce
I've produced this program that exhibits the behavior.

using System;
using System.Threading;
using System.Threading.Tasks;
using McMaster.Extensions.CommandLineUtils;
using Microsoft.Extensions.Hosting;

namespace ConsoleApp1
{
    class Program
    {
        static async Task<int> Main(string[] args)
        {
            return await new HostBuilder()
                .RunCommandLineApplicationAsync<MyProgram>(args);
        }
    }

    class MyProgram
    {
        protected int OnExecute(CommandLineApplication app, CancellationToken cancellationToken)
        {
            Console.WriteLine("Entered. Waiting 10s");
            for (int i = 0; i < 100; i++)
            {
                Thread.Sleep(100);
                if (cancellationToken.IsCancellationRequested)
                {
                    Console.WriteLine("Cancelled");
                    break;
                }
            }

            Console.WriteLine("Finished");

            return 0;
        }
    }
}

Expected behavior
Program terminates without exception.

Screenshots
When cancelling

When running till end

Additional context

Stacktrace thrown.

Unhandled Exception: System.ObjectDisposedException: Safe handle has been closed
   at System.Threading.WaitHandle.WaitOneNative(SafeHandle waitableSafeHandle, UInt32 millisecondsTimeout, Boolean hasThreadAffinity, Boolean exitContext)
   at System.Threading.WaitHandle.InternalWaitOne(SafeHandle waitableSafeHandle, Int64 millisecondsTimeout, Boolean hasThreadAffinity, Boolean exitContext)
   at McMaster.Extensions.Hosting.CommandLine.Internal.CommandLineLifetime.<>c__DisplayClass11_0.<WaitForStartAsync>b__1(Object _, EventArgs __)

[dtsao]

I'm seeing the same issue using McMaster.Extensions.Hosting.CommandLine Version="2.4.0-beta.81"

[natemcmaster]

Looks like a bug. I'll take a look before I release 2.4.0-rc. I have limited free time to work on this library, so if someone else is interested in taking a look, I would happy to review and merge a PR to fix this.

[natemcmaster]

Give 2.4.0-beta.94 a try and let me know if it doesn't resolve your issue.

https://www.myget.org/feed/natemcmaster/package/nuget/McMaster.Extensions.CommandLineUtils/2.4.0-beta.94

Install-Package McMaster.Extensions.CommandLineUtils -Version 2.4.0-beta.94 -Source https://www.myget.org/F/natemcmaster/api/v3/index.json

[Allann]

Installed v2.4.0-beta.99 and the error is gone.

[natemcmaster]

Try using the package manager UI instead: https://docs.microsoft.com/en-us/nuget/consume-packages/install-use-packages-visual-studio#package-sources

[Allann]

Thanks, I ended up doing that and installed beta 99 and I no longer see the exception during shutdown.

[natemcmaster]

Thanks for confirming.