Fix #85, remove numeric pipe ID from event string #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the number all that useful in this context? Maybe just remove from the message? |
Probably not, this was just the smallest change to make it safe. Truth is, only the "TO_LAB_RemovePacket" printed the pipe ID - the inverse operation in "TO_LAB_AddPacket" is almost identical except it doesn't print the pipe ID... |
Numeric pipe ID is not really relevant and fails when strict types are used. This makes "RemovePkt" consistent with "AddPkt" and takes it out of the event string.
jphickey
force-pushed
the
fix-85-printf-conversion
branch
from
ded1076
to
f0164b4
Compare
jphickey
changed the title
|
Updated per @skliper comment/suggestion ... this has the added bonus of fixing the complaint about whitespace/format check too. |
skliper
approved these changes
Mar 1, 2021
skliper
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Remove the numeric pipe ID from the event string, which solves the problem when strict types are used and the value isn't a simple integer.
Fixes #85
Testing performed
Build with strict resource ID types, confirm printf format specifier mismatch error in #85 is gone.
Expected behavior changes
No more compiler error.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.